Bug 1636178

Summary: [RFE] Report disk device name and serial number (qemu-guest-agent on Windows)
Product: Red Hat Enterprise Linux 8 Reporter: Jeff Nelson <jen>
Component: virtio-winAssignee: Yvugenfi <yvugenfi>
virtio-win sub component: qemu-ga-win QA Contact: Virtualization Bugs <virt-bugs>
Status: CLOSED DUPLICATE Docs Contact:
Severity: high    
Priority: high CC: ailan, jen, juzhang, lijin, michen, mtessun, phou, tgolembi, virt-bugs, virt-maint, wyu, xiagao
Version: 8.0Keywords: FutureFeature
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: 1635571
: 1636186 (view as bug list) Environment:
Last Closed: 2019-01-24 15:50:35 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1635571, 1636185, 1663092, 1687721    
Bug Blocks: 1636186    

Comment 2 Jeff Nelson 2018-10-04 16:36:17 UTC
Cloned for RHEL-8: BZ 1636186.

Comment 3 Tomáš Golembiovský 2018-10-31 09:01:43 UTC
the relevant patches are on their way upstream:

https://lists.nongnu.org/archive/html/qemu-devel/2018-10/msg06761.html

Comment 4 Sameeh Jubran 2018-11-27 11:43:35 UTC
I have rebased mingw-qemu-ga-win to qemu-3.1 which has all of thomas's patches, let's test it out:

http://brew-task-repos.usersys.redhat.com/repos/scratch/sjubran/mingw-qemu-ga-win/7.6.2/3.el7ev/noarch/

Comment 6 lijin 2018-12-03 05:48:11 UTC
xiagao,

Could you verify with the build in comment#4

Comment 7 xiagao 2018-12-11 03:19:02 UTC
qemu cmd line with two disks

-object secret,id=sec0,data=xiagao -drive file=win2019.luks,key-secret=sec0,format=luks,if=none,id=drive-ide0-0-0,cache=none -device ide-drive,bus=ide.0,unit=0,drive=drive-ide0-0-0,id=ide0-0-0,serial=MYDISK-1 \
-blockdev driver=file,cache.direct=off,cache.no-flush=on,filename=disk1.qcow2,node-name=data_disk_file \
-blockdev driver=qcow2,node-name=data_disk,file=data_disk_file \
-device virtio-blk-pci,bus=pcie-root-port-5,drive=data_disk,id=disk1,werror=stop,rerror=stop,serial=MYDISK-2 \



#nc -U /tmp/qga
{"execute":"guest-get-fsinfo" }
{"return": [{{"name": "\\\\?\\Volume{a9655429-0000-0000-0000-602200000000}\\", "total-bytes": 20897067008, "mountpoint": "C:\\", "disk": [{"serial": "MYDISK-1", "bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive0", "target": 0}], "used-bytes": 12038557696, "type": "NTFS"}, {"name": "\\\\?\\Volume{7a6cbe5e-0000-0000-0000-010000000000}\\", "total-bytes": 1070592000, "mountpoint": "F:\\", "disk": [{"serial": "MYDISK-2", "bus-type": "scsi", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive1", "target": 0}], "used-bytes": 17690624, "type": "NTFS"}, {"name": "\\\\?\\Volume{a9655429-0000-0000-0000-100000000000}\\", "mountpoint": "System Reserved", "disk": [{"serial": "MYDISK-1", "bus-type": "sata", "bus": 0, "unit": 0, "pci-controller": {"bus": -1, "slot": -1, "domain": -1, "function": -1}, "dev": "\\\\.\\PhysicalDrive0", "target": 0}], "type": "NTFS"}]}


For each "disk" entry in the output there are two new fields "dev" and
"serial".
Testing pass in this build.