Bug 1636184
| Summary: | Default module streams appeared post-Beta for Fedora 29, this seems reckless | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomas Toth <ttomasz> | ||||
| Component: | distribution | Assignee: | Josh Boyer <jwboyer> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | unspecified | Docs Contact: | |||||
| Priority: | unspecified | ||||||
| Version: | 29 | CC: | awilliam, dmach, fzatlouk, igor.raits, jmracek, kevin, mblaha, mboddu, mhatina, packaging-team-maint, robatino, rpm-software-management, sgallagh, vmukhame | ||||
| Target Milestone: | --- | Keywords: | Reopened | ||||
| Target Release: | --- | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2018-10-09 00:06:51 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1517013, 1517014 | ||||||
| Attachments: |
|
||||||
|
Description
Tomas Toth
2018-10-04 16:31:31 UTC
Created attachment 1490675 [details]
Tar-GZiped Output of dnf update --debugsolver
Proposing as Blocker/FreezeException based on the following criteria: "The installed system must be able appropriately to install, remove, and update software with the default console tool for the relevant software type." I assume, that Enabling module stream during an update, without the user's explicit request, violates the 'must be able to *appropriately* update'. This is entirely fine, because it is default stream. So end behaves as expected. I agree with Igor. It work like expected. It is technically fine but I'm not sure we should be adding new defaults to stable releases. It's not forbidden currently but it's confused a number of people. Yeah, I am not comfortable with introducing this default stream feature suddenly in post-Beta Fedora 29, if that's what happened. I was working on the assumption we would only get default module streams in F30+. This seems against at least the spirit of the Changes policy. That states that by the '100% code complete deadline' - which came before Beta - "New accepted changes must be code complete, meaning all the code required to enable to the new change is finished." This may technically have complied with that in that the *dnf-side code necessary for default module streams to exist* was "finished", I guess, but that seems like a tricksy way of looking at things. The clear intent of the requirement is that we get to test all the elements of the Change in the Beta, and since no default module streams (AFAIK) existed for F29 at Beta time, that was not the case. Just to clarify from my side (libgit2 maintainer): making module default didn't change libgit2/pygit2 versions, it was just about changing from traditional to modular. So ABI/API is fully compatible. For me it's not the contents that are of concern, but the mechanism itself and the policies / expectations around it. Discussed during the 2018-10-08 blocker review meeting: [1] The decision to punt (postpone decision) was made: "Punt to FESCo - this doesn't really violate the release criteria, but we are concerned about it as it relates to the Change process, so we will file a ticket asking FESCo to consider it" [1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2018-10-08/f29-blocker-review.2018-10-08-16.00.log.txt Just to make it clear, the libgit2 maintainer ignored the following requirement written on the module packaging guidelines page: "Setting or changing the default stream or the default installation profile requires a Fedora Change request, and it is only allowed in between Fedora releases."[1] We do have a policy around this which this change violates. It looks like it was merged by Mohan without proper review of the policy, so we need to figure out why that communication broke down. I'll look into that. I'm not sure how we want to proceed in this specific case, but based on other conversations I've had with Igor, I am not convinced this stream should be the default for libgit2 anyway. [1] https://docs.fedoraproject.org/en-US/modularity/making-modules/managing-defaults/ I've submitted a PR[1] to remove this as a default stream. It needs to go through the Change process for Fedora 30. I'm requesting a Freeze Exception on this BZ to allow Igor to pull in a non-modular RPM of the same version as was previously in the default module stream so we don't regress anything. [1] https://pagure.io/releng/fedora-module-defaults/pull-request/33 libgit2-0.27.5-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-abfd4c6ac3 https://pagure.io/releng/fedora-module-defaults/pull-request/33 has also been merged, so after tonight's compose, there will no longer be a default module stream for libgit2. libgit2-0.27.5-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-abfd4c6ac3 libgit2-0.27.5-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |