Bug 1636928

Summary: [ansible e2e] gluster ansible cleanup playbook doesn't remove the filesystem entries from fstab
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: bipin <bshetty>
Component: gluster-ansibleAssignee: Sachidananda Urs <surs>
Status: CLOSED ERRATA QA Contact: bipin <bshetty>
Severity: medium Docs Contact:
Priority: unspecified    
Version: rhgs-3.4CC: bshetty, rcyriac, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone: ---Keywords: ZStream
Target Release: RHGS 3.4.z Batch Update 1   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: gluster-ansible-roles-1.0.3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1636932 (view as bug list) Environment:
Last Closed: 2018-10-31 08:42:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1636932    
Attachments:
Description Flags
Playbooks to create and clean up bricks none

Description bipin 2018-10-08 10:00:46 UTC
Description of problem:
======================
The ansible cleanup in gluster infra doesn't remove the filesystem entries from the /etc/fstab.

Version-Release number of selected component (if applicable):
============================================================
gluster-ansible-infra-1.0.1-1.el7rhgs.noarch

How reproducible:
================
100%

Steps to Reproduce:
==================
1.Create a playbook that deploys gluster bricks
2.The entries are added to /etc/fstab
3.Now run the gluster ansible cleanup playbook, the filesystem entries still persists 


Actual results:
==============
The filesystem entries still persists

Expected results:
================
The entries should be cleaned


Additional info:
===============

Comment 1 Sachidananda Urs 2018-10-08 11:21:35 UTC
bipin, I was not able to reproduce this. What was the configuration that you used?

Is it possible that the entries you were seeing were from previous run? Which you may not have cleaned up using the reset role.

With the attached playbooks I got the expected results.

Comment 2 Sachidananda Urs 2018-10-08 11:24:23 UTC
Created attachment 1491621 [details]
Playbooks to create and clean up bricks

CLI:

$ ansible-playbook -i mount.inv create_brick.yml
$ ansible-playbook -i mount.inv cleanup.yml

Comment 3 bipin 2018-10-08 14:35:30 UTC
Sac,

Used the latest gluster playbook provided by Gobinda. I again could reproduce the issue. I am attaching the gluster inventory and cleanup file used.

Comment 6 Sachidananda Urs 2018-10-08 16:24:14 UTC
(In reply to bipin from comment #3)
> Sac,
> 
> Used the latest gluster playbook provided by Gobinda. I again could
> reproduce the issue. I am attaching the gluster inventory and cleanup file
> used.

Ah! We both were referring to different things.
I was referring to gluster.infra role. I’ll talk to Gobinda, this is a bug in the playbook.

Comment 7 bipin 2018-10-09 03:03:49 UTC
(In reply to Sachidananda Urs from comment #6)
> (In reply to bipin from comment #3)
> > Sac,
> > 
> > Used the latest gluster playbook provided by Gobinda. I again could
> > reproduce the issue. I am attaching the gluster inventory and cleanup file
> > used.
> 
> Ah! We both were referring to different things.
> I was referring to gluster.infra role. I’ll talk to Gobinda, this is a bug
> in the playbook.

Thanks for the clarification Sac!

Comment 8 Sachidananda Urs 2018-10-09 09:03:21 UTC
(In reply to bipin from comment #7)
> (In reply to Sachidananda Urs from comment #6)
> > (In reply to bipin from comment #3)
> > > Sac,
> > > 
> > > Used the latest gluster playbook provided by Gobinda. I again could
> > > reproduce the issue. I am attaching the gluster inventory and cleanup file
> > > used.
> > 
> > Ah! We both were referring to different things.
> > I was referring to gluster.infra role. I’ll talk to Gobinda, this is a bug
> > in the playbook.
> 
> Thanks for the clarification Sac!

Commit: https://github.com/gluster/gluster-ansible/pull/53/commits/6f4359b19f774 fixes the issue.

Comment 9 SATHEESARAN 2018-10-12 13:58:19 UTC
(In reply to Sachidananda Urs from comment #8)
> (In reply to bipin from comment #7)
> > (In reply to Sachidananda Urs from comment #6)
> > > (In reply to bipin from comment #3)
> > > > Sac,
> > > > 
> > > > Used the latest gluster playbook provided by Gobinda. I again could
> > > > reproduce the issue. I am attaching the gluster inventory and cleanup file
> > > > used.
> > > 
> > > Ah! We both were referring to different things.
> > > I was referring to gluster.infra role. I’ll talk to Gobinda, this is a bug
> > > in the playbook.
> > 
> > Thanks for the clarification Sac!
> 
> Commit:
> https://github.com/gluster/gluster-ansible/pull/53/commits/6f4359b19f774
> fixes the issue.

As the fix is already merged upstream, moving this bug to MODIFIED

Comment 10 SATHEESARAN 2018-10-12 14:03:32 UTC
(In reply to SATHEESARAN from comment #9)
> (In reply to Sachidananda Urs from comment #8)
> > (In reply to bipin from comment #7)
> > > (In reply to Sachidananda Urs from comment #6)
> > > > (In reply to bipin from comment #3)
> > > > > Sac,
> > > > > 
> > > > > Used the latest gluster playbook provided by Gobinda. I again could
> > > > > reproduce the issue. I am attaching the gluster inventory and cleanup file
> > > > > used.
> > > > 
> > > > Ah! We both were referring to different things.
> > > > I was referring to gluster.infra role. I’ll talk to Gobinda, this is a bug
> > > > in the playbook.
> > > 
> > > Thanks for the clarification Sac!
> > 
> > Commit:
> > https://github.com/gluster/gluster-ansible/pull/53/commits/6f4359b19f774
> > fixes the issue.
> 
> As the fix is already merged upstream, moving this bug to MODIFIED

Ignore my comment above. This bug lacking 3 way-acks, can't moved to MODIFIED

Comment 12 SATHEESARAN 2018-10-22 05:27:06 UTC
Verified with gluster-ansible-1.0.3 

Executing gluster cleanup playbook, fstab entries are removed

Comment 14 errata-xmlrpc 2018-10-31 08:42:30 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3428