Bug 1637015

Summary: [RFE] add option to disable toast notifications per user
Product: Red Hat Enterprise Virtualization Manager Reporter: Steffen Froemer <sfroemer>
Component: ovirt-engineAssignee: Greg Sheremeta <gshereme>
Status: CLOSED ERRATA QA Contact: samuel macko <smacko>
Severity: medium Docs Contact:
Priority: medium    
Version: 4.2.0CC: emarcus, gshereme, lleistne, lwright, mgoldboi, rdlugyhe, Rhev-m-bugs, sfroemer
Target Milestone: ovirt-4.3.1Keywords: FutureFeature
Target Release: 4.3.0Flags: lsvaty: testing_plan_complete-
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
With this release, users can now disable pop-up notifications. When a pop-up notification appears in the Administration Portal, the following options are now available for disabling notifications: - Dismiss All - Do Not Disturb - for 10 minutes - for 1 hour - for 1 day - until Next Log In
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-05-08 12:38:40 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: UX RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
notification Dismiss and Do Not Disturb buttons
none
notifications buttons demo none

Description Steffen Froemer 2018-10-08 13:10:28 UTC
1. Proposed title of this feature request
Any kind of message in new ovirt-engine UI is shown as popup in upper right corner. To not distract any interaction, these kind of messages should be placed somewhere else.

3. What is the nature and description of the request?
During work with UI one could run into the case, popping messages could overlay some buttons, which make it impossible to select them. It's required now, to confirm these messages first.


4. Why does the customer need this? (List the business requirements here)
The customer is doing different administrative tasks via UI and by these pop-ups, he's distracted and therefore he need to confirm those message first. This require additional time.

5. How would the customer like to achieve this? (List the functional requirements here)
The message popup should be shown on a position where not distracting or covering menus


6. For each functional requirement listed, specify how Red Hat and the customer can test to confirm the requirement is successfully implemented.
For example, change some Datacenter properties and the message should popup on different location than upper right.


7. Is there already an existing RFE upstream or in Red Hat Bugzilla?
no


8. Does the customer have any specific timeline dependencies and which release would they like to target (i.e. RHEL5, RHEL6)?
asap


9. Is the sales team involved in this request and do they have any additional input?
no

10. List any affected packages or components.
ovirt-engine

11. Would the customer be able to assist in testing this functionality if implemented?
yes

Comment 3 Greg Sheremeta 2018-10-08 22:43:05 UTC
The position of them follows our design standard, PatternFly. Example: https://www.patternfly.org/pattern-library/communication/toast-notifications/  (at the bottom)

What version of engine is this? It could also be the case that you're experiencing too many notifications and would like to disable them. We added this capability in a 4.2.z update. See Bug 1608362.

[The notifications are supposed to clear automatically after a few seconds, so you technically don't need to click the 'close' button on each of them.]

Comment 4 Steffen Froemer 2018-10-09 09:19:47 UTC
Hi Greg, 

they're running the latest version of engine. 
So the do not disturb functionality should be available. Is this something I can enable pro actively, based on my account or is it only possible to enable when 3 or more messages are shown.

The automatic-close feature might be fine, but when the message is covering required buttons, it's the same issue. I need to stop or interrupt my work to wait or confirm a message, before I can click on the button.

As the recommendation of patternfly, messages shown in top-right corner, is there a possibility to change this by some kind of configuration?

Comment 5 Greg Sheremeta 2018-10-18 16:48:08 UTC
(In reply to Steffen Froemer from comment #4)
> Hi Greg, 
> 
> they're running the latest version of engine. 
> So the do not disturb functionality should be available. Is this something I
> can enable pro actively, based on my account or is it only possible to
> enable when 3 or more messages are shown.

Currently it shows when 3, but we can make it configurable.

> 
> The automatic-close feature might be fine, but when the message is covering
> required buttons, it's the same issue. I need to stop or interrupt my work
> to wait or confirm a message, before I can click on the button.
> 
> As the recommendation of patternfly, messages shown in top-right corner, is
> there a possibility to change this by some kind of configuration?

I don't want to move the location, but we can add a feature to disable them per-user. Converting to an RFE.

Comment 6 Steffen Froemer 2018-12-12 06:03:32 UTC
(In reply to Greg Sheremeta from comment #5)

> 
> Currently it shows when 3, but we can make it configurable.
Yes, would make more sense. 

> 
> I don't want to move the location, but we can add a feature to disable them
> per-user. Converting to an RFE.
From UX perspective I does not like, if notification hide items, which I need for my work, but it's you, who will decide.
But I agree in adding feature to completely disable notification and also I would see only notification for tasks of current user-session.

Comment 7 Laura Wright 2018-12-14 13:49:47 UTC
From a UX and PatternFly perspective I think for the time being keeping the placement of the toast notifications but extending the capabilities of notification settings is the best option. I reached out to the larger UX group asking about notifications in other products and it sounds like others have been experiencing a similar issue with the placement of the toast notifications as well.

Comment 8 Greg Sheremeta 2018-12-14 23:46:18 UTC
We can easily tweak the current "Do Not Disturb" functionality and get a huge usability improvement.

Currently the buttons show when there are 3+ toast notifications showing, but we can just make the buttons show when any toasts are showing. Should be a tiny low risk change. Targeting for 4.3.

Comment 9 Steffen Froemer 2018-12-17 15:45:27 UTC
(In reply to Greg Sheremeta from comment #8)
> We can easily tweak the current "Do Not Disturb" functionality and get a
> huge usability improvement.
> 
> Currently the buttons show when there are 3+ toast notifications showing,
> but we can just make the buttons show when any toasts are showing. Should be
> a tiny low risk change. Targeting for 4.3.

I agree in doing this for the first step. But it still need to be configurable in future. If customer need to click DND-button every time he login again.
The best solution still might be only show notifications from the users tasks

Comment 10 Sandro Bonazzola 2019-01-28 09:44:20 UTC
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.

Comment 12 Greg Sheremeta 2019-01-31 02:11:58 UTC
Created attachment 1525219 [details]
notification Dismiss and Do Not Disturb buttons

Comment 13 Greg Sheremeta 2019-01-31 02:12:29 UTC
Created attachment 1525220 [details]
notifications buttons demo

Comment 14 Greg Sheremeta 2019-01-31 02:19:29 UTC
(In reply to Steffen Froemer from comment #9)
> (In reply to Greg Sheremeta from comment #8)
> > We can easily tweak the current "Do Not Disturb" functionality and get a
> > huge usability improvement.
> > 
> > Currently the buttons show when there are 3+ toast notifications showing,
> > but we can just make the buttons show when any toasts are showing. Should be
> > a tiny low risk change. Targeting for 4.3.
> 
> I agree in doing this for the first step.

For the first step, I've posted a patch and a demo of the 'Dismiss All' and 'Do Not Disturb' buttons working properly for 1+ Toast Notifications showing.

> But it still need to be configurable in future. If customer need to click DND-button every time he
> login again.

Not every login -- once per day is the maximum snooze time.

> The best solution still might be only show notifications from the users tasks

We can look into this later, but it will be some time before we get to it.

Comment 15 Greg Sheremeta 2019-02-20 11:17:54 UTC
>> The best solution still might be only show notifications from the users tasks
> We can look into this later, but it will be some time before we get to it.

Spinning out a new BZ 1679110

Comment 17 RHV bug bot 2019-02-21 17:26:09 UTC
WARN: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Found non-acked flags: '{'rhevm-4.3-ga': '?'}', ]

For more info please contact: rhv-devops

Comment 18 samuel macko 2019-02-27 13:20:18 UTC
Verified on ovirt-engine-4.3.1.1-0.1.el7.noarch.
Dismiss and snooze buttons are present and function correctly.

Comment 20 errata-xmlrpc 2019-05-08 12:38:40 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2019:1085