Bug 1637021

Summary: Installation should be aborted if module dependency errors are detected
Product: [Fedora] Fedora Reporter: Martin Kolman <mkolman>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 29CC: anaconda-maint-list, awilliam, fzatlouk, jonathan, kellin, mkolman, vanmeeuwen+fedora, vponcova, wwoods
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: AcceptedFreezeException
Fixed In Version: anaconda-29.24.4-1 anaconda-29.24.7-1.fc29 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-10-22 16:13:48 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1517014    

Description Martin Kolman 2018-10-08 13:18:57 UTC
Since DNF 3.6 DNF reports module dependency issues and Anaconda should abort the installation if such issues are detected, like it already does with broken packages and groups.

Otherwise there is the risk of silently installing a broken system.

NOTE: As this change requires DNF >=3.6, it needs to be coordinated with a DNF update.

Comment 1 Martin Kolman 2018-10-08 13:26:42 UTC
PR: https://github.com/rhinstaller/anaconda/pull/1642

Comment 2 Fedora Blocker Bugs Application 2018-10-08 13:51:52 UTC
Proposed as a Freeze Exception for 29-final by Fedora user m4rtink using the blocker tracking app because:

 Anaconda should make use of the new DNF 3.6 functionality to detect module dependency issues and abort the installation in such a case (as Anaconda already does for broken packages and groups).

Otherwise there is a risk we will silently install a broken system.

Comment 3 Adam Williamson 2018-10-08 15:39:53 UTC
3.6 already got pushed stable, so that's not a problem any more.

Comment 4 FrantiĊĦek Zatloukal 2018-10-08 18:06:42 UTC
Discussed during the 2018-10-08 blocker review meeting: [1]

The decision to classify this bug as an AcceptedFreezeException was made:

"This is clearly a useful and sensible protection and cannot be added post-release"

[1] https://meetbot-raw.fedoraproject.org/fedora-blocker-review/2018-10-08/f29-blocker-review.2018-10-08-16.00.log.txt

Comment 5 Fedora Update System 2018-10-18 14:05:12 UTC
anaconda-29.24.6-1.fc29 dnf-4.0.4-1.fc29 dnf-plugins-core-4.0.0-2.fc29 libblockdev-2.20-2.fc29 libdnf-0.22.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2789f6b6e7

Comment 6 Fedora Update System 2018-10-18 14:07:17 UTC
anaconda-29.24.6-1.fc29 dnf-4.0.4-1.fc29 dnf-plugins-core-4.0.0-2.fc29 libblockdev-2.20-2.fc29 libdnf-0.22.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-2789f6b6e7

Comment 7 Fedora Update System 2018-10-20 19:22:48 UTC
anaconda-29.24.7-1.fc29, dnf-4.0.4-1.fc29, dnf-plugins-core-4.0.0-2.fc29, libblockdev-2.20-2.fc29, libdnf-0.22.0-5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-2789f6b6e7

Comment 8 Fedora Update System 2018-10-22 16:13:48 UTC
anaconda-29.24.7-1.fc29, dnf-4.0.4-1.fc29, dnf-plugins-core-4.0.0-2.fc29, libblockdev-2.20-2.fc29, libdnf-0.22.0-5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.