Bug 1637512

Summary:	WebSocket push notifications no longer work in SUI
Product:	Red Hat CloudForms Management Engine	Reporter:	Dávid Halász <dhalasz>
Component:	UI - Service	Assignee:	Allen W <awight>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Niyaz Akhtar Ansari <nansari>
Severity:	medium	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.9.0	CC:	dhalasz, dmetzger, lavenel, obarenbo, simaishi
Target Milestone:	GA	Keywords:	TestOnly, ZStream
Target Release:	5.10.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	regression
Fixed In Version:	5.10.0.20	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1639351 (view as bug list)		Environment:
Last Closed:	2019-02-12 16:51:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1639351

Description Dávid Halász 2018-10-09 11:41:14 UTC

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:
You need to invoke any kind of notification.

Steps to Reproduce:
1. Log in into a fresh appliance in both UIs
2. Enable the Embedded Ansible Role in the OPS UI as admin
3. Wait for the notifications informing about the enablement appear in OPS UI
4. Look for the same notifications in the SUI

Actual results:
Notifications do not appear in SUI

Expected results:
Notifications should appear in SUI


Additional info:
Caused by https://github.com/ManageIQ/manageiq-ui-service/pull/1314

Comment 2 Dave Johnson 2018-10-09 11:45:13 UTC

Please assess the impact of this issue and update the severity accordingly.  Please refer to https://bugzilla.redhat.com/page.cgi?id=fields.html#bug_severity for a reminder on each severity's definition.

If it's something like a tracker bug where it doesn't matter, please set the severity to Low.

Comment 6 Allen W 2018-10-09 18:52:07 UTC

https://github.com/ManageIQ/manageiq-ui-service/pull/1482 and we got a pr

Comment 7 CFME Bot 2018-10-12 18:26:20 UTC

New commit detected on ManageIQ/manageiq-ui-service/hammer:

https://github.com/ManageIQ/manageiq-ui-service/commit/0d9b99cffa379f24dc1ba547ba8e8f5f11766b0b
commit 0d9b99cffa379f24dc1ba547ba8e8f5f11766b0b
Author:     Martin Hradil <himdel>
AuthorDate: Fri Oct 12 09:47:04 2018 -0400
Commit:     Martin Hradil <himdel>
CommitDate: Fri Oct 12 09:47:04 2018 -0400

    Merge pull request #1482 from AllenBW/bug/#1637512-broken-websockets

    BZ#1637512-Restore action cable subscription, ensure enablement flag is available

    (cherry picked from commit 3af8f1b78e1fef72ba059ce8552fe048331de03c)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1637512

 client/app/core/appliance-info.service.js | 3 +-
 client/app/core/appliance-info.service.spec.js | 3 +-
 client/app/core/authorization.config.js | 4 -
 client/app/core/event-notifications.service.js | 24 +-
 client/app/states/login/login.state.js | 4 -
 5 files changed, 27 insertions(+), 11 deletions(-)

Comment 9 Niyaz Akhtar Ansari 2018-11-09 12:04:03 UTC

WebSocket push notifications now works fine in SUI
Verified in Version 5.10.0.23.20181106165157_92dd189