Bug 1637901

Summary: [NMCI][abrt] [faf] NetworkManager: raise(): /usr/sbin/NetworkManager killed by 6
Product: Red Hat Enterprise Linux 7 Reporter: Vladimir Benes <vbenes>
Component: NetworkManagerAssignee: Beniamino Galvani <bgalvani>
Status: CLOSED ERRATA QA Contact: Desktop QE <desktop-qa-list>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.6CC: atragler, bgalvani, fgiudici, jmaxwell, lrintel, rkhan, sukulkar, thaller
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://faf.lab.eng.brq.redhat.com/faf/reports/bthash/ba9e175dda0a138004a9cdf67c8160f0a0da7222/
Whiteboard:
Fixed In Version: NetworkManager-1.18.0-0.3.20190408git43d9187c14.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-06 13:16:24 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1654714    

Description Vladimir Benes 2018-10-10 10:06:00 UTC
This bug has been created based on an anonymous crash report requested by the package maintainer.

Report URL: https://faf.lab.eng.brq.redhat.com/faf/reports/bthash/ba9e175dda0a138004a9cdf67c8160f0a0da7222/

Comment 2 Beniamino Galvani 2018-11-26 16:56:30 UTC
#0  in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/ra...
#1  in __GI_abort () at abort.c:90
#2  in g_assertion_message (domain=domain@entry=0x2aa0082f410 "NetworkMan...
#3  in g_assertion_message_expr (domain=domain@entry=0x2aa0082f410 "Netwo...
#4  in activate_stage5_ip4_config_result (self=0x2aa2f981d20) at src/devi...
#5  in activation_source_handle_cb (self=self@entry=0x2aa2f981d20, addr_f...
#6  in activation_source_handle_cb4 (user_data=user_data@entry=0x2aa2f981...
#7  in g_idle_dispatch (source=source@entry=0x2aa2f8f88b0, callback=0x2aa...
#8  in g_main_dispatch (context=0x2aa2f795a00) at gmain.c:3175
#9  in g_main_context_dispatch (context=context@entry=0x2aa2f795a00) at g...
#10 in g_main_context_iterate (context=0x2aa2f795a00, block=block@entry=1...
#11 in g_main_loop_run (loop=0x2aa2f795b40) at gmain.c:4097
#12 in main (argc=1, argv=0x3ffffd13bc8) at src/main.c:438

static void
activate_stage5_ip4_config_result (NMDevice *self)
{
    NMDevicePrivate *priv = NM_DEVICE_GET_PRIVATE (self);
    NMActRequest *req;
    const char *method;
    NMConnection *connection;
    int ip_ifindex;

    req = nm_device_get_act_request (self);
    g_assert (req); <=========================

Comment 3 Beniamino Galvani 2019-02-11 09:40:13 UTC
Fixed by commit:

commit 260cded3d6a1dc8d8aa02f126908dc1667f163ed
Author: Beniamino Galvani <bgalvani>
Date:   Fri Jul 6 17:47:30 2018 +0200

    device: destroy pending acd-managers when the device disconnects
    
    We previously kept any acd-manager running if the device was
    disconnected. It was possible to trigger a crash by setting a long
    dad-timeout and interrupting the activation request:
    
      nmcli con add type ethernet ifname eth0 con-name eth0+ ip4 1.2.3.4/32
      nmcli con mod eth0+ ipv4.dad-timeout 10000
      nmcli -w 2 con up eth0+
      nmcli con down eth0+
    
    After this, the n-acd timer would fire after 10 seconds and try to
    disconnect an already disconnected device, throwing the assertion:
    
      NetworkManager:ERROR:src/devices/nm-device.c:9845:
      activate_stage5_ip4_config_result: assertion failed: (req)
    
    Fixes: 28f6e8b4d2ae554042027cb7af261289eb07e1e4

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/commit/260cded3d6a1dc8d8aa02f126908dc1667f163ed

Comment 6 errata-xmlrpc 2019-08-06 13:16:24 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2302