Bug 1638317

Summary:	missing VDSM hook diskunmap in Node NG releases
Product:	[oVirt] ovirt-release	Reporter:	Andreas Elvers <andreas.elvers+redhat.bugzilla>
Component:	General	Assignee:	Sandro Bonazzola <sbonazzo>
Status:	CLOSED WONTFIX	QA Contact:	Lukas Svaty <lsvaty>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.2.2	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-25 07:08:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Node	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Andreas Elvers 2018-10-11 10:39:27 UTC

Description of problem:

Regarding bug #1440230 and the temporary fix (https://github.com/oVirt/vdsm/tree/master/vdsm_hooks/diskunmap) for the time being, there is a problem with oVirt Node NG releases. They lack this vdsm hook. So a node with Cinder/Ceph combo is unable to unmap freed space and will eventually suffocate in no space left on the core Ceph storage.


Version-Release number of selected component (if applicable):


How reproducible:

In a Ceph backed VM delete a file and fstrim the filesystem.

Steps to Reproduce:
1. within the VM: dd if=/dev/zero bs=1M of=/bug_testfile count=1024
2. note size increase of the image in Ceph
3. within VM: rm /bug_testfile && fstrim /
4. note size decrease of the image in Ceph

Actual results:

The size will not decrease.

Expected results:

The size should decrease.

Additional info:

Comment 1 Andreas Elvers 2018-10-11 10:41:29 UTC

*** Bug 1638318 has been marked as a duplicate of this bug. ***

Comment 2 Sandro Bonazzola 2018-10-11 11:57:28 UTC

Discussing the request to add the hook to oVirt Node NG here: https://lists.ovirt.org/archives/list/devel@ovirt.org/thread/Z6GZTUBGUECMJUU7ILFFUSRDGWDQ3OUR/

Comment 3 Sandro Bonazzola 2018-10-25 07:08:16 UTC

Closing won't fix being VDSM diskunmap hook considered a security issue.
Please note that you can still install it manually on oVirt Node with yum install: it will be persisted upon upgrades.

# yum install https://resources.ovirt.org/pub/ovirt-4.2/rpm/el7/noarch/vdsm-hook-diskunmap-4.20.39.1-1.el7.noarch.rpm