Bug 1638684
Summary: | VMware vCloud Provider's vApp Service Cannot be Fully Retired | ||
---|---|---|---|
Product: | Red Hat CloudForms Management Engine | Reporter: | mplesko |
Component: | Providers | Assignee: | mplesko |
Status: | CLOSED ERRATA | QA Contact: | mplesko |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 5.9.4 | CC: | dmetzger, gblomqui, jfrey, jhardy, jprause, lavenel, mplesko, obarenbo, simaishi, tfitzger |
Target Milestone: | GA | Keywords: | ZStream |
Target Release: | 5.9.5 | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | 5.9.5.2 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-11-05 14:00:33 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | vCloud | Target Upstream Version: | |
Embargoed: |
Description
mplesko
2018-10-12 09:14:00 UTC
New commit detected on ManageIQ/manageiq-providers-vmware/gaprindashvili: https://github.com/ManageIQ/manageiq-providers-vmware/commit/217b7a053372dad4ca4d0f329bde2c0ad745c636 commit 217b7a053372dad4ca4d0f329bde2c0ad745c636 Author: Miha Pleško <miha.plesko> AuthorDate: Wed Sep 26 10:21:42 2018 -0400 Commit: Miha Pleško <miha.plesko> CommitDate: Wed Sep 26 10:21:42 2018 -0400 [GA] Don't crash when probing deleted vApp for status With this commit we properly capture Fog exception which is raised when GET-ing vApp by ID when vApp doesn't exist anymore. Interesting enough, the fog-vcloud raises one of ```ruby Fog::Compute::VcloudDirector::Forbidden Fog::Compute::VcloudDirector::ServiceError ``` exceptions instead 404, depending on why exactly the entity couldn't be found :) With this commit we now capture the two exceptions and convert them to much more meaningful ``` MiqException::MiqOrchestrationStackNotExistError ``` to better reflect what's going on. Also, Automation is able to properly handle this kind of exception. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1638684 Signed-off-by: Miha Pleško <miha.plesko> app/models/manageiq/providers/vmware/cloud_manager/orchestration_stack.rb | 16 +- 1 file changed, 14 insertions(+), 2 deletions(-) Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2018:3466 |