Bug 1638904

Summary: lv-create.yml/lv-teardown.yml should fail if lv_vars.yaml has not been edited
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: John Harrigan <jharriga>
Component: Ceph-AnsibleAssignee: Ali Maredia <amaredia>
Status: CLOSED ERRATA QA Contact: Vasishta <vashastr>
Severity: low Docs Contact:
Priority: low    
Version: 3.2CC: anharris, aschoen, ceph-eng-bugs, frival, gmeno, kdreyer, nthomas, tchandra, tserlin, tunguyen, vashastr
Target Milestone: z2   
Target Release: 3.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: RHEL: ceph-ansible-3.2.34-1.el7cp Ubuntu: ceph-ansible_3.2.34-2redhat1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-12-19 17:58:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1641792    

Description John Harrigan 2018-10-12 18:30:20 UTC
Description of problem:
These playbooks will only succeed if user edits lv_vars.yaml file. User should be notified if lv_vars.yaml file has not been modified. 

Version-Release number of selected component (if applicable):
ceph-ansible 3.1.5

How reproducible:
always

Steps to Reproduce:
1. install ceph-ansible
2. execute playbook and see ansible fail for undefined var 'nvme_devices'

Actual results:
execute playbook and see ansible fail for undefined var 'nvme_devices'

Expected results:
execute playbook and see msg that user needs to edit the lv_vars.yaml file

Additional info:
We should consider making the naming conventions consistent with other ceph-ansible usage. For instance, provide a 'lv_vars.sample.yml' file that the user must copy and edit OR else the playbook fails and notifies user.

Comment 3 Ali Maredia 2018-10-29 06:02:58 UTC
PR for the issue is here: https://github.com/ceph/ceph-ansible/pull/new/wip-lv-vars-fail-undefined-nvme

Comment 4 Ali Maredia 2018-10-29 17:43:28 UTC
The above PR has been merged.

Comment 11 errata-xmlrpc 2019-12-19 17:58:55 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:4353