Bug 1638939

Here are the themes:

1. Make it easy to read
------------------------
a. It would be hard time figuring what are all the values that needs to changed and what not to. To help them, the values to be edited can be mentioned in angular braces. There is already a separate bug raised by Mugdha for the same.
Example:
lvsize=200G
should be there as: lvsize=<200G>

b. More comments for clarification.
For example: No clear statements provided for lvcache setup

c. Use the same variable names for vdo, VG, thinpool, lvcache,etc used in gdeploy configuration
use: 
vdo_sdb, vdo_sdc
gluster_vg_sdb, gluster_vg_sdc
gluster_thinpool_sdb, gluster_thinpool_sdc
lvcache, lvcachemeta

d. Do not use partitions in example, /dev/sdb1, vdo_sdb1, as do not really support that in RHHI deployment.

e. Example uses sdb, sdc while creating VDO, but while creating thinpool, only shows creation of thinpool on device sdb only. Keep the example consistent


2. The hash symbol that represent the comments could be organized
For example:
# With Dedupe & Compression
      #gluster_infra_volume_groups:
        #- vgname: vg_sdb1
          #pvname: /dev/mapper/vdo_sdb1
        #- vgname: vg_sdb2
          #pvname: /dev/mapper/vdo_sdb2

Expected:
# With Dedupe & Compression
      #gluster_infra_volume_groups:
      #  - vgname: vg_sdb1
      #    pvname: /dev/mapper/vdo_sdb1
      #  - vgname: vg_sdb2
      #    pvname: /dev/mapper/vdo_sdb2

2. Remove redundant definitions
--------------------------------
For each host 'gluster_infra_mount_devices' is defined twice. One would suffice, tested and it works.

Example:
Following definitions under the same host
<snip>
     gluster_infra_mount_devices:
        - path: /gluster_bricks/engine
          lvname: gluster_lv_engine
          vgname: vg_sdb1
        - path: /gluster_bricks/data
          lvname: gluster_lv_data
          vgname: vg_sdb2

# Mount the devices
      gluster_infra_mount_devices:
         - { path: '/gluster_bricks/data', vgname: vg_sdb2, lvname: gluster_lv_data }
         - { path: '/gluster_bricks/vmstore', vgname: vg_sdb2, lvname: gluster_lv_vmstore }
         - { path: '/gluster_bricks/engine', vgname: vg_sdb1, lvname: gluster_lv_engine }

</snip>

3. Remove using 'include' playbook
-----------------------------------
hc-ansible-deployment/he-deployment.yml uses 
'- include: add_hosts_storage_domains.yml'

It should be replaced by import_playbook, as 'include' is getting deprecated by ansible-2.8

I am attaching the playbook with above said ( comment1 ) changes.

Created attachment 1493464 [details]
Modified gluster_inventory file

Gobinda, can you take a look?

*** Bug 1634642 has been marked as a duplicate of this bug. ***

Please create a bug in gluster-ansible roles if required.

Now with RHVH 4.2.8 cockpit uses gluster-ansible roles, still we need this fix.
The reason behind this is that the user/customer may prefer to automate the deployment,
and prefer to use ansible-playbook without invoking gluster-ansible.

So in this cases, the fix is required and its needs to shipped through gluster-ansible-roles

(In reply to SATHEESARAN from comment #2)
> I am attaching the playbook with above said ( comment1 ) changes.

Why not contribute it upstream?

(In reply to Yaniv Kaul from comment #8)
> (In reply to SATHEESARAN from comment #2)
> > I am attaching the playbook with above said ( comment1 ) changes.
> 
> Why not contribute it upstream?

Thanks Yaniv. Yes, I have done the changes upstream and also its merged
https://github.com/gluster/gluster-ansible/pull/80

Verified with gluster-ansible-roles-1.0.5-10.el8rhgs

The template inventory file is available in the following location:
/etc/ansible/roles/gluster.ansible/playbooks/hc-ansible-deployment/gluster_inventory.yml

And this file has all the required updates and can be consumed for automated gluster deployment

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (RHHI for Virtualization 1.8 bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:3314