Bug 1638980

Summary: Review Request: gsrp5-webserver - Global system resource plаnnig web client
Product: [Fedora] Fedora Reporter: Nikolay chesnokov <nikolaychesnokov>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 29CC: eclipseo, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://www.gsrp5labs.com:8100
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-11-27 19:37:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 177841    

Description Nikolay chesnokov 2018-10-13 18:54:03 UTC
Spec URL: https://github.com/neo5g/gsrp5/tree/v1/webserver/rpm/gsrp5-webserver.spec
SRPM URL: https://github.com/neo5g/gsrp5/tree/v1/webserver/rpm/gsrp5-webserver-1.0.1-1.src.rpm
Description: Global system resource planning - Web client
Fedora Account System Username:nchesnokov

Comment 1 Robert-André Mauchin 🐧 2018-10-19 16:30:41 UTC
 - Use %global, not %define

 - Source0: must be a URL pointing to the upstream archive

 - Group: BuildRoot: Prefix: Vendor: Packager: must not be used in Fedora

 - Not needed:

%clean
rm -rf $RPM_BUILD_ROOT
 
 - env CFLAGS="$RPM_OPT_FLAGS" python3 setup.py build → %py3_build

 - python3 setup.py install -O1 --root=$RPM_BUILD_ROOT --record=INSTALLED_FILES → %py3_install

 - Not needed:

%defattr(-,root,root)

 - You need to include a %changelog

 - http://www.gsrp.org/ is 404

 - AGPL-3 is not a valid license shorthand, it should be AGPLv3

 - You're missing the BuildRequires for a python package


Read the guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/

and https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/

Comment 2 Ben Cotton 2019-10-31 20:37:56 UTC
This message is a reminder that Fedora 29 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 29 on 2019-11-26.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '29'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 29 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2019-11-27 19:37:12 UTC
Fedora 29 changed to end-of-life (EOL) status on 2019-11-26. Fedora 29 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.