Bug 1639058

Summary:	Review Request: python-wsproto - WebSockets state-machine based protocol implementation
Product:	[Fedora] Fedora	Reporter:	Carl George 🤠 <carlwgeorge>
Component:	Package Review	Assignee:	Luis Bazan <bazanluis20>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	bazanluis20, package-review
Target Milestone:	---	Flags:	bazanluis20: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-10-15 15:58:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Carl George 🤠 2018-10-14 22:14:36 UTC

Spec URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-responder/fedora-rawhide-x86_64/00809190-python-wsproto/python-wsproto.spec
SRPM URL: https://copr-be.cloud.fedoraproject.org/results/carlwgeorge/python-responder/fedora-rawhide-x86_64/00809190-python-wsproto/python-wsproto-0.12.0-1.fc30.src.rpm


Description:
wsproto is a pure-Python implementation of a WebSocket protocol stack.  It is
written from the ground up to be embeddable in whatever program you choose to
use, ensuring that you can communicate via WebSockets, as defined in RFC6455,
regardless of your programming paradigm.

wsproto does not provide a parsing layer, a network layer, or any rules about
concurrency.  Instead, it is a purely in-memory solution, defined in terms of
data actions and WebSocket frames.  RFC6455 and Compression Extensions for
WebSocket via RFC7692 are fully supported.

wsproto supports Python 2.7 and 3.5 or higher.


Fedora Account System Username: carlwgeorge

Comment 1 Luis Bazan 2018-10-15 14:52:20 UTC

Rpmlint
-------
Checking: python3-wsproto-0.12.0-1.fc28.noarch.rpm
          python-wsproto-0.12.0-1.fc28.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.

[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any
     that are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

[x]: Package contains BR: python2-devel or python3-devel
[x]: Binary eggs must be removed in %prep

[x]: License field in the package spec file matches the actual license.

[x]: Latest version is packaged.

[x]: %check is present and all tests pass.

[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

Comment 2 Luis Bazan 2018-10-15 15:17:19 UTC

I build and test in vm all is OK.

cheers,

approved +1

Comment 3 Gwyn Ciesla 2018-10-15 15:48:21 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-wsproto

Comment 4 Carl George 🤠 2018-10-15 15:58:55 UTC

https://koji.fedoraproject.org/koji/buildinfo?buildID=1153618

Comment 5 Fedora Update System 2018-10-15 16:18:29 UTC

python-wsproto-0.12.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcc0471b75

Comment 6 Fedora Update System 2018-10-16 15:51:36 UTC

python-wsproto-0.12.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-fcc0471b75

Comment 7 Fedora Update System 2018-10-30 17:27:46 UTC

python-wsproto-0.12.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.