Bug 1639108

Summary: libosinfo test suite should collect+report all failures, not exit on first error
Product: [Community] Virtualization Tools Reporter: Vera Budikova <vbudikov>
Component: libosinfoAssignee: Vera Budikova <vbudikov>
Status: CLOSED UPSTREAM QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: berrange, cfergeau, crobinso, fidencio
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-09 10:07:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Enhance test isodetect continue after failure none

Description Vera Budikova 2018-10-15 06:05:33 UTC 
Description of problem:
isodetect test does not end after the first failing 

Version-Release number of selected component (if applicable):
libosinfo-1.2.0-1.el8.x86_64

How reproducible:
always

Steps to Reproduce:
1. Have minimally 1 corrupted isodetect testfile
2. Run isodetect test
3.

Actual results:
../build-aux/test-driver: line 107: 15107 Trace/breakpoint trap   (core dumped) "$@" > $log_file 2>&1

/isodetect/opensuse: OK
/isodetect/popos: OK
/isodetect/fedora: 
** (/home/test/rpmbuild/BUILD/libosinfo-1.2.0/tests/.libs/lt-test-isodetect:15107): ERROR **: 01:58:06.772: ISO Fedora-Server-dvd-x86_64-27-1.6.iso.txt was not matched by OS fedora27
FAIL test-isodetect (exit status: 133)

Expected resultL
All tests are executed and results are collected

Additional info:
Comment 1 Cole Robinson 2018-10-15 12:25:50 UTC 
All tests work like this and I find it quite annoying as well, so hopefully it's an easy fix
Comment 2 Vera Budikova 2018-10-15 17:23:47 UTC 
Created attachment 1494096 [details]
Enhance test isodetect continue after failure
Comment 3 Fabiano Fidêncio 2018-10-15 17:32:24 UTC 
(In reply to Vera Budikova from comment #2)
> Created attachment 1494096 [details]
> Enhance test isodetect continue after failure

Věra,

Please, submit the patch using git-send-email to our libosinfo mailing list.

All the reviews will be done there!
Comment 4 Fabiano Fidêncio 2018-10-19 06:34:29 UTC 
master:
 cc6dac8425770e66ef8f012691b5e80f3926659e
 3e2190ba12142af998ea3c8d29c8ac866e60d1ca
Comment 5 Fabiano Fidêncio 2018-10-19 06:52:29 UTC 
Ops, I just now noticed that Cole has changed the bug description.

I'll leave it as ASSIGNED (to Věra) till we have the following tests changed:
- test-mediauris
- test-treeuris
- test-os-resources (maybe?)
Comment 6 Fabiano Fidêncio 2018-11-09 10:07:21 UTC 
master:
  ca410f9f874ce3f042105dd628e0f2b2336d6948