Bug 1639329

Summary: Ansible error handling rescue block does not have any indication that the block's failure is being handled by rescue.
Product: [oVirt] ovirt-ansible-collection Reporter: Kevin Alon Goldblatt <kgoldbla>
Component: engine-setupAssignee: James <jtanner>
Status: CLOSED DEFERRED QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: omachace
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Unspecified   
Whiteboard: ansible
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-01 14:48:18 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: External RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1639335    

Description Kevin Alon Goldblatt 2018-10-15 13:31:38 UTC
Description of problem:
We are opening this bug as a tracker as it affects our ovirt-ansible roles. Feel free to change the component as needed.

This bug is based on the issues found in the bugs below:

https://github.com/ansible/ansible/issues/39227
https://github.com/ansible/ansible/issues/40130

Ansible error handling rescue block does not have any indication that the block's failure is being handled by rescue.
Ansible error handling rescue block does not give any indication in the output log, that the block's failure is being handled in rescue. Rather the output logs show that one task has failed, but still it is continuing the execution with next task. Just by looking at the logs it does not give any information that rescue tasks are under execution unless we add debug task indicating the same (or) by browsing through the playbooks. This m
ake life difficult in debugging playbooks with multiple roles in identify real failure.If we take the example of retry tasks failures have clear prefix "FAILED - RETRYING: ", if we take the "ignore_errors" case there is a clear print statement "...ignoring" before proceeding to the next task. It would make debugging easy if we have similar sort of indication for block-rescue tasks as well.


Version-Release number of selected component (if applicable):
ansible 2.6.3
  config file = /etc/ansible/ansible.cfg
  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, Feb 20 2018, 09:19:12) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]


How reproducible:
100%

Steps to Reproduce:
1. In block that includes a task, using a rescue, the failure is being ignored and the rescue is ignored
2.
3.

Actual results:
The failure is ignored

Expected results:
The failure should not be ignored

Additional info:

Comment 6 Michal Skrivanek 2020-03-18 15:47:20 UTC
This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 7 Michal Skrivanek 2020-03-18 15:52:04 UTC
This bug didn't get any attention for a while, we didn't have the capacity to make any progress. If you deeply care about it or want to work on it please assign/target accordingly

Comment 8 Michal Skrivanek 2020-04-01 14:48:18 UTC
ok, closing. Please reopen if still relevant/you want to work on it.

Comment 9 Michal Skrivanek 2020-04-01 14:51:31 UTC
ok, closing. Please reopen if still relevant/you want to work on it.