Bug 163949
Summary: | bad handling of command line options for kudzu | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Gilles J. Seguin <segg.gill> | ||||
Component: | kudzu | Assignee: | Bill Nottingham <notting> | ||||
Status: | CLOSED RAWHIDE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 4 | CC: | rvokal | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | i386 | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | 1.1.118-1 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-07-23 01:43:15 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 150222 | ||||||
Attachments: |
|
Description
Gilles J. Seguin
2005-07-22 11:01:58 UTC
Hm... 'kudzu -p -c audio' shows all of those as well? There's nothing obvious with the code there, and unfortunately, I don't have any boxes with ISAPnP to test at the moment. isapnp.c:381 in function isapnpProbe() the line is if ( probeClass & dev->type ) which is supposed to remove the dev struct if it is not of the required deviceClass (here may be CLASS_AUDIO) since by default dev->type is CLASS_UNSPEC which is ~0 this thing is always true we want if ( ( dev->type != CLASS_UNSPEC && probeClass & dev->type ) || ( probeClass == CLASS_UNSPEC && dev->type == CLASS_UNSPEC ) ) Created attachment 117085 [details]
simple fix
Try this.
i am happy your your fix. Which is closing the bug report the patch in comment #3 from Bill Nottingham is more in line with what other bus are reporting, we have now line class: OTHER instead of class: UNSPEC present output, with comment #3 patch # kudzu -p --safe --kernel=2.6 --bus=isapnp --class=audio - class: AUDIO bus: ISAPNP detached: 0 driver: snd-cs4236 desc: "CS4236 - CSC0000" deviceId: CSC0000 pdeviceId: CSC0b36 # kudzu -p --safe --kernel=2.6 --bus=isapnp --class=unspec - class: OTHER bus: ISAPNP detached: 0 driver: ns558 desc: "CS4236 - CSC0001" deviceId: CSC0001 pdeviceId: CSC0b36 - class: OTHER bus: ISAPNP detached: 0 driver: unknown desc: "CS4236 - CSC0003" deviceId: CSC0003 pdeviceId: CSC0b36 - class: OTHER bus: ISAPNP detached: 0 driver: unknown desc: "CS4236 - CSC0010" deviceId: CSC0010 pdeviceId: CSC0b36 - class: AUDIO bus: ISAPNP detached: 0 driver: snd-cs4236 desc: "CS4236 - CSC0000" deviceId: CSC0000 pdeviceId: CSC0b36 nice work Bill Fixed in 1.1.118-1, in the FC5 devel tree. |