Bug 1639717

Summary:	symlinks seems to break flatpak apps
Product:	[Fedora] Fedora	Reporter:	Eduardo Minguez <eminguez>
Component:	paper-icon-theme	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	paper-icon-theme-1.5.0-2.fc29 paper-icon-theme-1.5.0-2.fc28	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-14 01:58:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eduardo Minguez 2018-10-16 12:45:58 UTC

Description of problem:
By using absolute symlinks, the flatpak apps cannot open the icons so they fail to start.

See https://github.com/flatpak/flatpak/issues/2149 for more information.


Version-Release number of selected component (if applicable):
paper-icon-theme-1.5.0-1.fc28.noarch


How reproducible:
Install paper-icon-theme and flatpak, set icon to paper and try to run any flatpak app (for instance org.gabmus.hydrapaper)

Steps to Reproduce:
1.
2.
3.

Actual results:
Gtk:ERROR:gtkiconhelper.c:494:ensure_surface_for_gicon: assertion failed (error == NULL): Failed to load /run/host/share/icons/Paper/48x48/status/image-missing.png: Error opening file /run/host/share/icons/Paper/48x48/status/image-missing.png: No such file or directory (g-io-error-quark, 1)


Expected results:
App works fine

Additional info:

Comment 1 Fabio Valentini 2018-10-16 13:45:16 UTC

That's interesting ...

I checked, and not de-duplicating files with symlinks blows up the size of the package by about a factor of 2, so I don't think that's desirable.

De-duplicating the files with hardlinks instead of symlinks seems to work, but the build crashes on fedora 28.

I don't know what a good solution would be. I'll post my findings on the github issue as well, maybe someone there can help.

Comment 2 Eduardo Minguez 2018-10-16 13:51:56 UTC

Maybe the fix is just replacing absolute symlinks for relative symlinks only (I'm just speaking out loud here, I have no idea)

Comment 3 Fabio Valentini 2018-10-16 13:58:04 UTC

That may solve the issue, but doing that is not supported by the file de-duplication macro (which reads like whichcraft to me):

https://src.fedoraproject.org/rpms/fdupes/blob/master/f/macros.fdupes

Comment 4 Fedora Update System 2019-02-05 22:25:31 UTC

paper-icon-theme-1.5.0-2.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-6e40282ec8

Comment 5 Fedora Update System 2019-02-05 22:27:30 UTC

paper-icon-theme-1.5.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-3338c14d5a

Comment 6 Fedora Update System 2019-02-06 04:35:28 UTC

paper-icon-theme-1.5.0-2.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-6e40282ec8

Comment 7 Fedora Update System 2019-02-08 02:15:33 UTC

paper-icon-theme-1.5.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-3338c14d5a

Comment 8 Fedora Update System 2019-02-14 01:58:03 UTC

paper-icon-theme-1.5.0-2.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2019-02-16 01:24:28 UTC

paper-icon-theme-1.5.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.