Bug 1640592

Summary: Custom button[Template/Image]: after dialog execution not return to Detail page
Product: Red Hat CloudForms Management Engine Reporter: Nikhil Dhandre <ndhandre>
Component: UI - OPSAssignee: eclarizi
Status: CLOSED CURRENTRELEASE QA Contact: Nikhil Dhandre <ndhandre>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: unspecified    
Version: 5.9.5CC: dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.22 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1643263 (view as bug list) Environment:
Last Closed: 2019-02-12 16:53:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1643263    
Attachments:
Description Flags
Object behavior none

Description Nikhil Dhandre 2018-10-18 11:23:54 UTC
Created attachment 1495261 [details]
Object behavior

Description of problem:
-----------------------
This BZ, I found whiling automating... For "Template and Image" objects when we execute custom button with dialog it should return to exact detail page from where execution started. but Detail page linking to ("Service>workload").

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
Version 5.9.5.2.20181015201954_5f1530c


How reproducible:
-----------------
100%

Steps to Reproduce:
-------------------
1. Create a custom button with "Template and Image" object. Use simple dialog
2. navigate to compute> cloud > Instance
3. select Images
4. select any image
5. execute custom button on it> dialog window > submit
6. It will return to the Detail page of the image but its wrong. check for the "vertical navigation bar"

Actual results:
---------------
The detail page is not exact from where we executed. Its linked to "Service > workloads".


Expected results:
-----------------
It should return to the same detail page where we start execution means "Compute>Instance>"


Additional info:
---------------
Attaching gif file for more clarification. showing Instance object and Template/Image object behavior.

Comment 2 Nikhil Dhandre 2018-10-18 11:30:37 UTC
This applicable to Version 5.10.0.20 as well. We can reproduce this with cloud or infra provider.

Comment 4 CFME Bot 2018-10-24 09:11:56 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/71487182b6b79fb36e00070f339fb4cb354c7d4a
commit 71487182b6b79fb36e00070f339fb4cb354c7d4a
Author:     Erik Clarizio <eclarizio>
AuthorDate: Thu Oct 18 13:22:54 2018 -0400
Commit:     Erik Clarizio <eclarizio>
CommitDate: Thu Oct 18 13:22:54 2018 -0400

    Fix vm_cloud image custom button return and cancel endpoints

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640592

 app/services/dialog_local_service.rb | 2 +-
 spec/services/dialog_local_service_spec.rb | 16 +-
 2 files changed, 14 insertions(+), 4 deletions(-)

Comment 7 CFME Bot 2018-10-24 15:31:46 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/4f15fcea315d3e5698ee9db55837af5c0d823b37
commit 4f15fcea315d3e5698ee9db55837af5c0d823b37
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Wed Oct 24 05:09:21 2018 -0400
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Wed Oct 24 05:09:21 2018 -0400

    Merge pull request #4795 from eclarizio/BZ1640592

    Fix vm_cloud image custom button return and cancel endpoints

    (cherry picked from commit ff14ca698bf6d2314f424318845975254f8274bd)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1640592

 app/services/dialog_local_service.rb | 2 +-
 spec/services/dialog_local_service_spec.rb | 16 +-
 2 files changed, 14 insertions(+), 4 deletions(-)

Comment 9 Nikhil Dhandre 2018-11-01 11:19:53 UTC
tested with the latest working fine.