Bug 1640626

Proposing this for F29 FE.

sgallagh is preparing a fix for this.

+1 FE, would be nice if we can avoid changing the package with the .repo files post release because users can be editing the .repo files as well and then we leave .rpmnew files behind etc.

+1 FE as well.

+1 FE

To record the problem: all of the repositories in the fedora-workstation-repositories packages were installed as basic files, rather than as %config(noreplace). The result is that every update of that package will reset any of those repository files to enabled=0, enabled_metadata=1, resulting in the repo not getting updates.

The patches I sent in https://src.fedoraproject.org/rpms/fedora-workstation-repositories/pull-request/3 and https://src.fedoraproject.org/rpms/fedora-workstation-repositories/pull-request/5 fixes this and needs to be pushed to F28, F29 and Rawhide.

fedora-workstation-repositories-29-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-109c48fcbb

fedora-workstation-repositories-28-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1bd2b1fbcf

Accepted on 2018-10-18 after the amount of votes in-bug had reached an appropriate level:

The decision to classify this bug as an "AcceptedFreezeException" was made as this bug will prevent users of the Google Chrome repo from accessing updates to Google Chrome and could pose potential security risks as such.

Proposed as a Blocker for 29-final by Fedora user sgallagh using the blocker tracking app because:

 "A fedora-release package containing the correct names, information and repository configuration for a final Fedora release must be present on release-blocking images".

"correct [...] repository configuration" should include not overwriting local changes (like enablement).

I think this is potentially a candidate to be considered a 0day blocker, since it will only affect updates from older versions.

The fix is already built and pushed, but in case the fix is incomplete, it should probably have a ruling made.

fedora-workstation-repositories-29-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-109c48fcbb

I can confirm that the new package preserves existing modifications to those files (including the case when upgrading from an old package without %config(noreplace)).

Discussed during the 2018-10-18 Fedora 29 Go/No-Go meeting: [1]

The decision to classify this bug as an "AcceptedBlocker" was made as this would silently disable third-party repos shipped in the fedora-workstation-repositories package, preventing upgrades and security patches to those packages, and violating the blocker criteria surrounding repositories.

[1] https://meetbot-raw.fedoraproject.org/fedora-meeting-1/2018-10-18/f29-final-go_no_go-meeting.2018-10-18-17.00.log.txt

fedora-workstation-repositories-28-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1bd2b1fbcf

fedora-workstation-repositories-29-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.

fedora-workstation-repositories-28-3.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report.

FYI This happened in the KDE Spin as well, when I upgraded from F28 to F29