Bug 1641386

Hi and welcome to Fedora.

First problem:

 - Python 2 is deprecated in Fedora 30, would it be possible to build it with Python 3 instead? Otherwise this package won't be accepted as is. We don't accept anything Python 2 related anymore.


Your SPEC is rot really in line with the Guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/

I will go over the issues:

 - Group is not used in Fedora, neither is Buildroot: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections

 - Please add a comment for each patch explaining why they are needed:

Patch0:         not_null_argument_for_strcmp.patch
Patch1:         werror.patch

 - AGPL-3.0 is not a valid shorthand. See the list here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

License:        AGPLv3

 - Release is missing its dist tag:

Release:        1%{?dist}

 - %setup -q -n %{name}-%{version}
 
%patch0 -p1
%patch1 -p1

You could use %autosetup -p1

 - make -C src → %make_build

Although, reading the Makefile, I wonder if it would not be better to do

pushd src/
%py2_build
popd

That way it would respect Fedora build flags.

 - The install location is wrong, it should use %{_libdir}:

mkdir -p %{buildroot}/%{_libdir}/security

   And:

%{_libdir}/security/pam_python.so

 - make -C src install LIBDIR=%{buildroot}/%{_lib}/security → %make_install -C src LIBDIR=%{_libdir}/security

 - Not needed: %defattr(-,root,root)

 - The license must be installed with %license, not %doc

%license agpl-3.0.txt

 - Add the examples in %doc

%doc examples

 - Build the doc/ with Sphinx and add them to %doc

%doc doc/html

 - Add your %changelog entry

%changelog
* Tue Oct 23 2018 Alexander Naumov <posix.ru> - 1.0.6-1
- Initial release

 - Source0 is 404. It should be:

Source:         https://sourceforge.net/projects/%{name}/files/%{name}-%{version}-1/%{name}-%{version}.tar.gz

 - Also you're missing: 

BuildRequires:  gcc

Hi Robert,
thanks a lot for your review.
Unfortunately, it seems that at the moment it can't work without python2. Migration to python3 is "in progress", but it's not done right now.
https://sourceforge.net/p/pam-python/tickets/5/#f4bb

If it can't be accepted with python2 dependency, we should wait...

Thanks again.

Cheers,
Alex

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

This is an automatic action taken by review-stats script.

The ticket submitter failed to clear the NEEDINFO flag in a month.
As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews
we consider this ticket as DEADREVIEW and proceed to close it.