Bug 1641570

Summary: gluster-block: Fix minor rpm-build warnings
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Prasanna Kumar Kalever <prasanna.kalever>
Component: gluster-blockAssignee: Amar Tumballi <atumball>
Status: CLOSED ERRATA QA Contact: Neha Berry <nberry>
Severity: medium Docs Contact:
Priority: low    
Version: ocs-3.11CC: bgoyal, knarra, kramdoss, nberry, pkarampu, pprakash, prasanna.kalever, rhs-bugs, sankarshan, vbellur, xiubli
Target Milestone: ---Keywords: ZStream
Target Release: OCS 3.11.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: gluster-block-0.2.1-29.el7rhgs Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-07 03:38:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1641915, 1644154    

Description Prasanna Kumar Kalever 2018-10-22 08:41:21 UTC
Description of problem:

Fix minor rpm build warnings

$ rpmbuild --quiet -ta gluster-block-0.3tar.gz
In file included from common.h:15:0,
from common.c:12:
common.c: In function 'glusterBlockParseSize':
common.c:104:11: warning: format '%lld' expects argument of type 'long long int', but argument 3 has type 'ssize_t {aka long int}' [-Wformat=]
MSG("The size %lld will align to sector size %d bytes\n",
^
utils.h:132:29: note: in definition of macro 'MSG'
fprintf(stdout, fmt, VA_ARGS); 
^~~
utils.h:178:27: warning: format '%lld' expects argument of type 'long long int', but argument 5 has type 'ssize_t {aka long int}' [-Wformat=]
fprintf(fd, "[%s] %s: " fmt " [at %s+%d :<%s>]\n", 
^
common.c:106:7: note: in expansion of macro 'LOG'
LOG(dom, GB_LOG_ERROR,
^~~
common.c:107:38: note: format string is defined here
"The target device size %lld is will align to the sector size %d",
~~~^
%ld
utils.c:20:24: warning: missing braces around initializer [-Wmissing-braces]
struct gbConf gbConf = {LRU_COUNT_DEF, GB_LOG_INFO, GB_LOGDIR, '\0', '\0', '\0', '\0', '\0', '\0', 0};
^
{ }
621 blocks

Comment 2 Prasanna Kumar Kalever 2018-10-22 08:43:00 UTC
PR: https://github.com/gluster/gluster-block/pull/141

Comment 12 errata-xmlrpc 2019-02-07 03:38:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0285