Bug 1641669

Summary: 404 Not Found: When dialog submitted via custom button from datastore object with method and dialog both attached
Product: Red Hat CloudForms Management Engine Reporter: Satoe Imaishi <simaishi>
Component: UI - OPSAssignee: Zita Nemeckova <znemecko>
Status: CLOSED ERRATA QA Contact: Nikhil Dhandre <ndhandre>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.9.0CC: cpelland, dmetzger, hkataria, lavenel, mpovolny, obarenbo, simaishi, smallamp, znemecko
Target Milestone: GAKeywords: ZStream
Target Release: 5.9.8   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: custom_button:datastore
Fixed In Version: 5.9.8.0 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1574403 Environment:
Last Closed: 2019-02-12 13:58:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:
Bug Depends On: 1574403    
Bug Blocks:    

Comment 2 CFME Bot 2018-10-22 13:41:27 UTC
New commit detected on ManageIQ/manageiq-ui-classic/gaprindashvili:

https://github.com/ManageIQ/manageiq-ui-classic/commit/6669028a9b8f05213fac26eb481277fdb50e7ded
commit 6669028a9b8f05213fac26eb481277fdb50e7ded
Author:     Martin Hradil <himdel>
AuthorDate: Mon Oct 22 08:41:32 2018 -0400
Commit:     Martin Hradil <himdel>
CommitDate: Mon Oct 22 08:41:32 2018 -0400

    Merge pull request #4745 from ZitaNemeckova/fix_error_handling_open_url

    Fix error for Datastore custom button

    (cherry picked from commit fe7f419cc67c659a3bcabadc63a2cb334c1d4aed)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641669
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641670

 app/assets/javascripts/controllers/dialog_user/dialog_user_controller.js | 25 +-
 app/controllers/application_controller/buttons.rb | 3 +-
 app/views/shared/dialogs/_dialog_provision.html.haml | 1 +
 spec/javascripts/controllers/dialog_user/dialog_user_controller.spec.js | 1 -
 4 files changed, 20 insertions(+), 10 deletions(-)

Comment 6 Satoe Imaishi 2019-01-21 15:09:50 UTC
Gaprindashvili backport details:

$ git log -1
commit 4eb9880d32dc8d4d13ce5a2b328d1d73a88d6d89
Author: Milan Zázrivec <mzazrivec>
Date:   Thu May 10 11:42:38 2018 +0200

    Merge pull request #3893 from ZitaNemeckova/fix_dialog_datastore
    
    Fix Dialog's API call for Datastore
    
    (cherry picked from commit 8d1fc0f314bb6402dc809d77769b986664e953e7)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641669

Comment 8 Nikhil Dhandre 2019-02-06 18:02:44 UTC
Tested on Version 5.9.8.0.20190121201402_b1df4c2

working fine.

Comment 10 errata-xmlrpc 2019-02-12 13:58:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0315