Bug 1641810

New commit detected on ManageIQ/manageiq/gaprindashvili:

https://github.com/ManageIQ/manageiq/commit/256263f4d31da72725f0aaa7362ac55f7c5b12a0
commit 256263f4d31da72725f0aaa7362ac55f7c5b12a0
Author:     Joe Rafaniello <jrafanie.github.com>
AuthorDate: Mon Oct 22 11:26:24 2018 -0400
Commit:     Joe Rafaniello <jrafanie.github.com>
CommitDate: Mon Oct 22 11:26:24 2018 -0400

    Merge pull request #18114 from gtanzillo/fix-tag-expression-on-not-taggable-class

    Check if class is taggable before attempting to process tag expression

    (cherry picked from commit 6fa29c26a8dbb3c8935dfc4d521b6971073d3655)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1641810

 lib/rbac/filterer.rb | 2 +-
 spec/lib/rbac/filterer_spec.rb | 18 +
 2 files changed, 19 insertions(+), 1 deletion(-)

Hi , 

I have set up an appliance https://10.8.196.243. 
Restored DB . 
Service - request does not show any requests.
I ordered one request and it is showing fine .
Please check once .

Thanks, 
Shveta

> Restored DB . 
Service - request does not show any requests.
I ordered one request and it is showing fine .

Hi Shveta,

Login as admin and verify which user role has the managed/tag filter that contains a tag expression.  Create a user for yourself that has this role and then try to login as them.  Then, if you have requests in your database, if you go to services -> requests, this page will fail to load with an error (before the fix).  Once that is verified, try it on the fixed version, it should load with no issues.

I'll be online in a few hours if you have any questions.  Please contact me on gitter or ask me here.  Thanks!

Thanks,
Joe

Please have a look at 10.8.199.237.
Getting error while restoring DB .
http://pastebin.test.redhat.com/663694

Hi Shveta, Looking at the pastebin, it seems that the error you are getting during the restore is due to the fact that the DB has open connections -

pg_restore: [archiver (db)] could not execute query: ERROR:  cannot drop the currently open database
    Command was: DROP DATABASE vmdb_production;

After that there are errors/warnings on every table it tries to restore.

You need to make sure that all connections are closed before attemting to drop and restore the DB

Hi Shveta, I posted this directly to you but will copy this here.  The steps for this BZ are causing you to hit numerous errors. One, what GreggT posted in comment #6.  Also, you're hitting the issue during fix_auth being looked at in bug #1643250.

While, it would be great to be able to use this exact database to recreate the problem and then verify the new build fixes it, it's not necessary.

You can do one of the following:
1) Use an existing database export containing services and a user role with a tag filter (Managed -> environment -> production) that does get through fix_auth... or

2) Take an empty database.  Create a new user role, from an existing one, add a Managed -> environment -> production tag for that user role, assign a group to this role, and add a user into this group.  As an admin, create a request, such as a provision request, then try to login as the user with this production tag.  With the old codebase, if you go to requests, it will blow up with the reported find_tagged_with error.  With the fixed code, it will show the request, since requests don't participate in tag based filtering.

Part 1) should say "Use an existing database export containing requests"... not services

We can continue to investigate the issues you're having with this specific database export outside of this bugzilla.

Hi Joe , 

Verified this BZ with the steps in part 2 mentioned above.
Appliance - https://10.8.198.15
Verison - 5.9.5.3.20181023135339_256263f 
Created a role bz_role in appliance .
Created a group tagged with Environment- Production .
User belonging to that group .
Created request .
Logged in as user , request shows without error .
Please take a look once before I move it to verified .

That looks good to me Shveta

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2018:3466