Bug 1642002

Summary:	cockpit-docker is installed (and docker as dependency) even if you just want to use cri-o
Product:	OpenShift Container Platform	Reporter:	Eduardo Minguez <eminguez>
Component:	Installer	Assignee:	Scott Dodson <sdodson>
Status:	CLOSED ERRATA	QA Contact:	Qin Ping <piqin>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	3.11.0	CC:	aos-bugs, gpei, jokerman, mmccomas
Target Milestone:	---	Keywords:	Reopened
Target Release:	3.11.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-20 03:11:52 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eduardo Minguez 2018-10-23 11:07:39 UTC

Description of problem:

Trying to install a cri-o only node installs docker as well even if the variables are configured as:

openshift_use_crio_only: true
openshift_use_crio: true

The issue is the /roles/openshift_node/defaults/main.yml requires 'cockpit-docker' to be installed.


Version-Release number of the following components:

[cloud-user@shiftstack-ansibler ~]$ rpm -q openshift-ansible
openshift-ansible-3.11.16-1.git.0.4ac6f81.el7.noarch
[cloud-user@shiftstack-ansibler ~]$ rpm -q ansible
ansible-2.6.5-1.el7ae.noarch
[cloud-user@shiftstack-ansibler ~]$ ansible --version
ansible 2.6.5
  config file = /home/cloud-user/ansible.cfg
  configured module search path = [u'/home/cloud-user/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']
  ansible python module location = /usr/lib/python2.7/site-packages/ansible
  executable location = /usr/bin/ansible
  python version = 2.7.5 (default, May 31 2018, 09:41:32) [GCC 4.8.5 20150623 (Red Hat 4.8.5-28)]

How reproducible:
Install some node with cri-o as explained before

Steps to Reproduce:
1.
2.
3.

Actual results:
cockpit-docker is installed then docker as well as dependency

Expected results:
cockpit-docker is not installed, neither docker

Additional info:

Comment 1 Eduardo Minguez 2018-10-23 12:20:08 UTC

Just in case:

rpm -qR cockpit-docker
/usr/bin/docker
/usr/lib/systemd/system/docker.service
cockpit-bridge >= 122
cockpit-shell >= 122
python2
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1

Comment 2 Scott Dodson 2018-10-23 12:25:44 UTC

Thanks, the workaround would be to disable cockpit. 

osm_use_cockpit=false

Since this is removed from the product in 4.0 and 3.11 has already shipped I don't see us fixing this.

Comment 3 Eduardo Minguez 2018-10-23 14:24:58 UTC

I'm not sure if that's enough as the cockpit-docker package is in the 'default_r_openshift_node_image_prep_packages' variable in https://github.com/openshift/openshift-ansible/blob/master/roles/openshift_node/defaults/main.yml#L69

Comment 4 Eduardo Minguez 2018-10-24 08:28:59 UTC

Just in case I've created this PR https://github.com/openshift/openshift-ansible/pull/10501

Comment 5 Scott Dodson 2018-10-26 19:47:26 UTC

https://github.com/openshift/openshift-ansible/pull/10524 release-3.11 backport

Comment 7 Qin Ping 2018-11-04 02:48:26 UTC

Verified with configuration:
openshift_use_crio_only: true
openshift_use_crio: true
osm_use_cockpit=false

openshift-ansible version:
openshift-ansible-docs-3.11.38-1.git.0.d146f83.el7.noarch.rpm

# rpm -qR cockpit-docker
package cockpit-docker is not installed

Comment 9 errata-xmlrpc 2018-11-20 03:11:52 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:3537