Bug 1643469
Summary: | Upgrade warning during cleanup: lib/client: remove failed: No such file or directory | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Severin Gehwolf <sgehwolf> |
Component: | java-11-openjdk | Assignee: | jiri vanek <jvanek> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 29 | CC: | jerboaa, jvanek, zzambers |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | java-11-openjdk-11.0.2.7-6.fc28 java-11-openjdk-11.0.2.7-7.fc29 java-11-openjdk-11.0.2.7-7.fc30 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2019-04-05 01:55:04 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1679639 | ||
Bug Blocks: |
Description
Severin Gehwolf
2018-10-26 10:25:31 UTC
What exactly makes you think that depends on bug 1679639? See this proposed fix which worked for me: https://src.fedoraproject.org/rpms/java-11-openjdk/pull-request/34 Maybe I am wrong, but I think non-existance of jsa archive alone would not cause this issue. There is some kind of cleanup phase in copy-jdk-configs which is responsible for messages like this. I think problem happens when JDK package installs empty directories, and these are not listed in blacklist in copy-jdk-configs [1]. C-j-c then remove these (empty directories) and that causes messages like this. I don't know reasoning behind this step (jvanek should know), but see also: [2] This problem is very annoying and was causing TPS failures when new dirs were added to JDK (tps check for failed, error pattern in rpm's output). I complained about this problem on our mailing list multiple times in the past. And even though fedora now seems to include env. variable to add files to that blacklist, this is not the case on RHEL... But I hope this can be solved in a way that no blacklist/whitelist would be necessary in c-j-c. [1] https://pagure.io/copy_jdk_configs/blob/1d18ce8b5dec47a0468136ab6cdadfb93defe2c4/f/copy_jdk_configs_fixFiles.sh#_191 [2] https://bugzilla.redhat.com/show_bug.cgi?id=1624517 That is, I think (old) package actually created that directory [1] (empty), but it was removed by c-j-c in post script [2] [3]: [1] https://src.fedoraproject.org/rpms/java-11-openjdk/pull-request/34#_1__29 [2] https://src.fedoraproject.org/fork/jerboaa/rpms/java-11-openjdk/blob/d1487a99f29ae1a0ad523ec2196dcac04023b0c5/f/java-11-openjdk.spec#_355 [3] https://pagure.io/copy_jdk_configs/blob/1d18ce8b5dec47a0468136ab6cdadfb93defe2c4/f/copy_jdk_configs_fixFiles.sh#_213 Note to myself: I think I know why c-j-c removes these empty directories. I think when old JDK already has some modified/backup conf. files (e.g. .rpmsave), these files with their empty parent dirs would be kept on the system. It was probably discovered, that just removing old rpmsave files does not help. I guess rpm internally composes list of files to remove (old JDK) before running new JDK's post script and empty dirs would therefore be kept. (And that's why that cleanup step exist...) However if I am right, there should be better solution for this problem. when removing old modified/backup conf. files, not only remove them, but continue with their parent dirs as long as they are empty. But this would need proper testing... (This should have same effect as current ugly solution (when It happens to work), but there would be no need blacklist.) ps: c-j-c needs to better comments/documentation, so there is no mysterious behaviour, where nobody remembers what was its original purpose. (In reply to zzambers from comment #2) > There is some kind of cleanup phase in copy-jdk-configs which is responsible > for messages like this. I think problem happens when JDK package installs > empty directories, and these are not listed in blacklist in copy-jdk-configs > [1]. C-j-c then remove these (empty directories) and that causes messages > like this. I don't know reasoning behind this step (jvanek should know), but > see also: [2] Right. But packaging empty directories which are never going to contain any files (we don't build a client JVM, IIRC) is a bug in the package to me. That is not to say that we shouldn't also fix c-j-c :) In a different bug, though. Sure, I am not against that fix at all. What I was trying to say is that warning message is not about existence/non-existence of jsa, it's caused by bug/limitation of c-j-c (triggered by that empty dir). It's just coincidence that it uncovered non-existing jsa -> unnecessary dir. :) java-11-openjdk-11.0.2.7-7.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-c474104ebb java-11-openjdk-11.0.2.7-6.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2019-649ac90900 Note: The first version which got fixed is java-11-openjdk-11.0.2.6. This upgrade issue will only be solved once a user upgrades a JDK 11 version >= java-11-openjdk-11.0.2.6 to a higher version. java-11-openjdk-11.0.2.7-6.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-649ac90900 java-11-openjdk-11.0.2.7-7.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-ac496c1055 java-11-openjdk-11.0.2.7-7.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-c474104ebb java-11-openjdk-11.0.2.7-7.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-ac496c1055 java-11-openjdk-11.0.2.7-6.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. java-11-openjdk-11.0.2.7-7.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. java-11-openjdk-11.0.2.7-7.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. |