Bug 1643934

Summary:	Emit a warning before running vdsm-tool restore-nets
Product:	[oVirt] ovirt-hosted-engine-setup	Reporter:	Polina <pagranat>
Component:	Network	Assignee:	Simone Tiraboschi <stirabos>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Polina <pagranat>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	---	CC:	bugs, danken, guillaume.pavese, michal.skrivanek, stirabos
Target Milestone:	ovirt-4.3.0	Flags:	rule-engine: ovirt-4.3+ rule-engine: exception+
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-hosted-engine-setup-2.3.0	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-13 07:43:09 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Polina 2018-10-29 13:25:01 UTC

Description of problem:the 'vdsm-tool restore-nets'  must be replaced with 
'vdsm-tool clear-nets' as the more sutable  in /usr/sbin/ovirt-hosted-engine-cleanup.

Version-Release number of selected component (if applicable):
DS ovirt-hosted-engine-setup-2.2.30

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Dan Kenigsberg 2018-10-31 08:46:51 UTC

Network team would love to consult, but I believe that the Hosted Engine code is owned by Integration team.

Comment 2 Sandro Bonazzola 2018-11-12 08:34:40 UTC

Dan, any way to ensure we don't loose network connectivity?

Comment 3 Dan Kenigsberg 2018-11-12 09:26:12 UTC

(In reply to Sandro Bonazzola from comment #2)
> Dan, any way to ensure we don't loose network connectivity?

`vdsm-tool clear-nets` suggested by Polina should not cause connectivity loss, as it keeps the ovirtmgmt interface unchanged. Do you have a different experience?

Comment 4 Simone Tiraboschi 2018-11-12 09:37:46 UTC

(In reply to Dan Kenigsberg from comment #3)
> (In reply to Sandro Bonazzola from comment #2)
> > Dan, any way to ensure we don't loose network connectivity?
> 
> `vdsm-tool clear-nets` suggested by Polina should not cause connectivity
> loss, as it keeps the ovirtmgmt interface unchanged. Do you have a different
> experience?

The point is that we want to use it on ovirt-hosted-engine-cleanup to completely clean up the host including removing the management bridge.
Maybe 'vdsm-tool restore-nets' is still more appropriate for that.

Comment 5 Sandro Bonazzola 2018-11-19 08:23:47 UTC

Let's add a warning if we find an already configured network and keep restore.

Comment 6 Polina 2019-01-31 07:59:43 UTC

verified on ovirt-hosted-engine-setup-2.3.4-0.0.master.20190125093207.git6c233f5.el7.noarch

Comment 7 Sandro Bonazzola 2019-02-13 07:43:09 UTC

This bugzilla is included in oVirt 4.3.0 release, published on February 4th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.