Bug 164451

Summary: [PATCH] NM dies when wrong WEP key entered
Product: [Fedora] Fedora Reporter: Bill Moss <bmoss>
Component: NetworkManagerAssignee: Dan Williams <dcbw>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: high    
Version: 4CC: jpmahowald
Target Milestone: ---Keywords: Patch
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-10-10 01:21:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch for NetworkManagerDevice.c none

Description Bill Moss 2005-07-27 22:42:44 UTC 
Description of problem: NM dies when wrong WEP key entered in the Passphrase dialog


Version-Release number of selected component (if applicable): CVS HEAD 1.436


How reproducible: Every time


Steps to Reproduce: 
* Login as user with no NM gconf or keyring data stored, NM service running,
nm-applet running, AP broadcasting its essid

* Click on progress bar for AP

* Note the gconf now contains the essid and timestamp

* type wrong HEX WEP key in Passphrase dialog and enter the default keyring
password when prompted. OK

* NM service dies but PID file still exists. nm-applet still running.

* gconf now also contains the key_type

* restart the NM service

* enter correct HEX WEP key.

* connection made and WEP key updated in keyring.
  
Actual results: NM dies.


Expected results: After a failure to connect, NM should display an error message
telling the user that the WEP key is wrong.

Additional info:
Comment 1 Bill Moss 2005-07-28 23:15:03 UTC 
Created attachment 117252 [details]
patch for NetworkManagerDevice.c

The patch fixes the bug reported above. Under the conditions described, the
allowed_ap is NULL at the point when the auth_meth for the allowed_ap is first
updated. This update can be avoided using an if statement.
Comment 2 Dan Williams 2005-10-10 01:21:27 UTC 
Ok, updated and committed to CVS.  Thanks for the ping.