Bug 1644770
| Summary: | Remove_from_disk method is leaving VMs in an Orphaned State for VMware Provider | |||
|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | myoder | |
| Component: | Providers | Assignee: | Adam Grare <agrare> | |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Kedar Kulkarni <kkulkarn> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | high | |||
| Version: | 5.9.3 | CC: | agrare, bwoolf, dmetzger, gblomqui, jfrey, jhardy, jprause, kkulkarn, mkanoor, myoder, obarenbo, simaishi, tfitzger | |
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | |
| Target Release: | 5.10.0 | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | 5.10.0.28 | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1654436 (view as bug list) | Environment: | ||
| Last Closed: | 2019-02-12 16:50:37 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | Bug | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | VMware | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1622587, 1654436 | |||
|
Comment 12
CFME Bot
2018-11-14 18:25:40 UTC
New commit detected on ManageIQ/manageiq/master: https://github.com/ManageIQ/manageiq/commit/f24984bc5ee749e0f6f284fac4271db288eb406c commit f24984bc5ee749e0f6f284fac4271db288eb406c Author: Adam Grare <agrare> AuthorDate: Wed Nov 14 13:17:05 2018 -0500 Commit: Adam Grare <agrare> CommitDate: Wed Nov 14 13:17:05 2018 -0500 Disconnect storage when disconnecting the VM Instead of having the EventHandler call disconnect_storage from an event handler, call it when disconnecting the VM. https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/vm_or_template.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commit detected on ManageIQ/manageiq-providers-vmware/master: https://github.com/ManageIQ/manageiq-providers-vmware/commit/772e1d3f26fee088a6c4d8938da1548970cccf2a commit 772e1d3f26fee088a6c4d8938da1548970cccf2a Author: Adam Grare <agrare> AuthorDate: Wed Nov 14 13:14:49 2018 -0500 Commit: Adam Grare <agrare> CommitDate: Wed Nov 14 13:14:49 2018 -0500 Check EmsEvents when disconnecting storage Instead of the EventHandler calling disconnect_storage when DestroyVM_Task_Complete is processed check the ems_events for UnregisterVM_Complete. https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared.rb | 1 + app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/disconnect.rb | 27 + 2 files changed, 28 insertions(+) New commit detected on ManageIQ/manageiq-content/master: https://github.com/ManageIQ/manageiq-content/commit/0fee98baa97d9a9dd8753fdd4d4d64bf332a30de commit 0fee98baa97d9a9dd8753fdd4d4d64bf332a30de Author: Adam Grare <agrare> AuthorDate: Wed Nov 14 13:11:34 2018 -0500 Commit: Adam Grare <agrare> CommitDate: Wed Nov 14 13:11:34 2018 -0500 Disconnect storage when disconnecting a VM Instead of calling disconnect_storage separately from the targeted refresh, disconnect the storage when disconnect_inv is called from the targeted refresh. https://bugzilla.redhat.com/show_bug.cgi?id=1644770 content/automate/ManageIQ/System/Event/EmsEvent/EVM.class/destroyvm_task_complete.yaml | 2 - content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/user_remove_vm_finished.yaml | 4 +- 2 files changed, 1 insertion(+), 5 deletions(-) New commit detected on ManageIQ/manageiq-providers-ovirt/master: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/8e9eaa064d81b9ae332953bf61c6c9be63290f63 commit 8e9eaa064d81b9ae332953bf61c6c9be63290f63 Author: Adam Grare <agrare> AuthorDate: Wed Nov 14 13:21:17 2018 -0500 Commit: Adam Grare <agrare> CommitDate: Wed Nov 14 13:21:17 2018 -0500 No need to override disconnect_inv from core Core is going to call disconnect_storage from disconnect_inv so no need to override it. https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/manageiq/providers/redhat/infra_manager/vm.rb | 6 - 1 file changed, 6 deletions(-) New commit detected on ManageIQ/manageiq/gaprindashvili: https://github.com/ManageIQ/manageiq/commit/a79c4db3bcaa83e5665782c04f71ff13126a3afd commit a79c4db3bcaa83e5665782c04f71ff13126a3afd Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 28 10:29:37 2018 -0500 Commit: Jason Frey <fryguy9> CommitDate: Wed Nov 28 10:29:37 2018 -0500 Merge pull request #18200 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms Disconnect storage when disconnecting the VM (cherry picked from commit 3e466eb1f562fba5743a8c4cbb66bf900b8e6a21) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/ems_event/automate.rb | 4 - app/models/vm_or_template.rb | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) New commit detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/952c1fcc58cf3f4604825bcd67001d2efb3d32ce commit 952c1fcc58cf3f4604825bcd67001d2efb3d32ce Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 28 10:29:37 2018 -0500 Commit: Jason Frey <fryguy9> CommitDate: Wed Nov 28 10:29:37 2018 -0500 Merge pull request #18200 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms Disconnect storage when disconnecting the VM (cherry picked from commit 3e466eb1f562fba5743a8c4cbb66bf900b8e6a21) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/ems_event/automate.rb | 4 - app/models/vm_or_template.rb | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) New commit detected on ManageIQ/manageiq-automation_engine/hammer: https://github.com/ManageIQ/manageiq-automation_engine/commit/449522d7a70cf5cc7eda82598ab8279011c4c459 commit 449522d7a70cf5cc7eda82598ab8279011c4c459 Author: Greg McCullough <gmccullo> AuthorDate: Wed Nov 28 14:04:56 2018 -0500 Commit: Greg McCullough <gmccullo> CommitDate: Wed Nov 28 14:04:56 2018 -0500 Merge pull request #272 from agrare/disconnect_storage_no_op Make disconnect_storage a no-op (cherry picked from commit d9dcef8ce15f9b51766bed4ef65c41397a900122) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 lib/miq_automation_engine/engine/miq_ae_engine/miq_ae_builtin_method.rb | 5 +- lib/miq_automation_engine/service_models/miq_ae_service_ems_event.rb | 3 +- spec/service_models/miq_ae_service_ems_event_spec.rb | 2 +- 3 files changed, 6 insertions(+), 4 deletions(-) New commit detected on ManageIQ/manageiq-content/hammer: https://github.com/ManageIQ/manageiq-content/commit/dd7ae8254c258f6e638ba05027304bc24a579fd6 commit dd7ae8254c258f6e638ba05027304bc24a579fd6 Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 28 10:32:54 2018 -0500 Commit: Jason Frey <fryguy9> CommitDate: Wed Nov 28 10:32:54 2018 -0500 Merge pull request #472 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms Disconnect storage when disconnecting a VM (cherry picked from commit 6032cc1a9861563d800893a22ca7583a2e776076) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 content/automate/ManageIQ/System/Event/EmsEvent/EVM.class/destroyvm_task_complete.yaml | 2 - content/automate/ManageIQ/System/Event/EmsEvent/RHEVM.class/user_remove_vm_finished.yaml | 4 +- 2 files changed, 1 insertion(+), 5 deletions(-) New commit detected on ManageIQ/manageiq-providers-vmware/hammer: https://github.com/ManageIQ/manageiq-providers-vmware/commit/3b5065cf14adeb3c733734ca47ebc7a2b584cf83 commit 3b5065cf14adeb3c733734ca47ebc7a2b584cf83 Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 28 10:32:26 2018 -0500 Commit: Jason Frey <fryguy9> CommitDate: Wed Nov 28 10:32:26 2018 -0500 Merge pull request #336 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms Check EmsEvents when disconnecting storage (cherry picked from commit f73e67f64056d8a56ac78597824203ac58671319) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared.rb | 1 + app/models/manageiq/providers/vmware/infra_manager/vm_or_template_shared/disconnect.rb | 27 + 2 files changed, 28 insertions(+) New commit detected on ManageIQ/manageiq-providers-ovirt/hammer: https://github.com/ManageIQ/manageiq-providers-ovirt/commit/5ca2e09839ba378c0de6993270983916154cb986 commit 5ca2e09839ba378c0de6993270983916154cb986 Author: Jason Frey <fryguy9> AuthorDate: Wed Nov 28 10:33:37 2018 -0500 Commit: Jason Frey <fryguy9> CommitDate: Wed Nov 28 10:33:37 2018 -0500 Merge pull request #310 from agrare/bz_1644770_disconnect_storage_when_disconnecting_vms No need to override disconnect_inv from core (cherry picked from commit b3afbb248d40d472e90d797d0fd59ee3086e2ffc) https://bugzilla.redhat.com/show_bug.cgi?id=1644770 app/models/manageiq/providers/redhat/infra_manager/vm.rb | 6 - 1 file changed, 6 deletions(-) |