Bug 1644848
Summary: | VM refuses to start: can't apply global IvyBridge-IBRS-x86_64-cpu.osxsave=on | |||
---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Patrick O'Callaghan <poc> | |
Component: | qemu | Assignee: | Fedora Virtualization Maintainers <virt-maint> | |
Status: | CLOSED DEFERRED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
Severity: | unspecified | Docs Contact: | ||
Priority: | unspecified | |||
Version: | 29 | CC: | amit, berrange, cfergeau, crobinso, dwmw2, itamar, pbonzini, poc, rjones, virt-maint | |
Target Milestone: | --- | Keywords: | Reopened | |
Target Release: | --- | |||
Hardware: | Unspecified | |||
OS: | Unspecified | |||
Whiteboard: | ||||
Fixed In Version: | Doc Type: | If docs needed, set a value | ||
Doc Text: | Story Points: | --- | ||
Clone Of: | ||||
: | 1723633 (view as bug list) | Environment: | ||
Last Closed: | 2019-03-28 21:26:20 UTC | Type: | Bug | |
Regression: | --- | Mount Type: | --- | |
Documentation: | --- | CRM: | ||
Verified Versions: | Category: | --- | ||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
Cloudforms Team: | --- | Target Upstream Version: | ||
Embargoed: | ||||
Bug Depends On: | ||||
Bug Blocks: | 1723633 |
Description
Patrick O'Callaghan
2018-10-31 17:18:42 UTC
The "osxsave" property was removed from QEMU upstream as it was never actually exposed to the guests. I expect that your existing guest has this CPU flag encoded in its XML config, as it was a previously supported flag. Fixing it should be as simple as "virsh edit $guest" as root and delete the mention of "osxsave" feature flag. Newly provisioned guests shouldn't get given this flag in the first place, only upgraded guests will suffer. (In reply to Daniel Berrange from comment #1) > The "osxsave" property was removed from QEMU upstream as it was never > actually exposed to the guests. > > I expect that your existing guest has this CPU flag encoded in its XML > config, as it was a previously supported flag. > > Fixing it should be as simple as "virsh edit $guest" as root and delete the > mention of "osxsave" feature flag. > > Newly provisioned guests shouldn't get given this flag in the first place, > only upgraded guests will suffer. That solved it, thanks. Curiously, a Windows 10 guest, also inherited from F28, does not have this problem as the osxsave feature was not set. I've no idea why. Maybe the problematic guest was in fact installed under an even earlier Fedora release than the Windows guest ? In any case, while this is a genuine problem, I don't think we're going to try todo anything to automagically remove the flags on upgrade, so i'm moving this to WONTFIX. (In reply to Daniel Berrange from comment #3) > Maybe the problematic guest was in fact installed under an even earlier > Fedora release than the Windows guest ? > > In any case, while this is a genuine problem, I don't think we're going to > try todo anything to automagically remove the flags on upgrade, so i'm > moving this to WONTFIX. In fact it's the oher way round. The Windows guest was installed over a year ago. The Fedora guest is only a couple of months old at most. (In reply to Patrick O'Callaghan from comment #4) > (In reply to Daniel Berrange from comment #3) > > Maybe the problematic guest was in fact installed under an even earlier > > Fedora release than the Windows guest ? > > > > In any case, while this is a genuine problem, I don't think we're going to > > try todo anything to automagically remove the flags on upgrade, so i'm > > moving this to WONTFIX. > > In fact it's the oher way round. The Windows guest was installed over a year > ago. The Fedora guest is only a couple of months old at most. FYI an attempt to create a new VM triggered this error again. Since the VM XML file was never created, I had to track down the offending line in /usr/share/libvirt/cpu_map/x86_features.xml and remove it. (In reply to Patrick O'Callaghan from comment #5) > (In reply to Patrick O'Callaghan from comment #4) > > (In reply to Daniel Berrange from comment #3) > > > Maybe the problematic guest was in fact installed under an even earlier > > > Fedora release than the Windows guest ? > > > > > > In any case, while this is a genuine problem, I don't think we're going to > > > try todo anything to automagically remove the flags on upgrade, so i'm > > > moving this to WONTFIX. > > > > In fact it's the oher way round. The Windows guest was installed over a year > > ago. The Fedora guest is only a couple of months old at most. > > FYI an attempt to create a new VM triggered this error again. Since the VM > XML file was never created, I had to track down the offending line in > /usr/share/libvirt/cpu_map/x86_features.xml and remove it. Removing the line from /usr/share/libvirt/cpu_map/x86_features.xml didn't fix the problem. I'm still getting a complaint about .osxsave so presumably it's being set somewhere else. Reopening. Patrick can you provide: * full virt-manager --debug output from app startup to reproducing the bug * /var/log/libvirt/qemu/$vmname.log , for the VM name you are trying to create * output of: sudo virsh domcapabilities (In reply to Cole Robinson from comment #7) > Reopening. Patrick can you provide: > > * full virt-manager --debug output from app startup to reproducing the bug > * /var/log/libvirt/qemu/$vmname.log , for the VM name you are trying to > create > * output of: sudo virsh domcapabilities On a second attempt, the error refuses to show itself. I tried both with and without the change to /usr/share/libvirt/cpu_map/x86_features.xml and it made no difference. I can only assume it's because I rebooted after some system updates (though these were not to qemu or libvirt directly). Now on kernel 4.19.13-300.fc29.x86_64 if it matters. Sorry for the noise. I'll come back to this if it happens again. |