Bug 1645112

Summary: Container Review Request: origin-tests - origin-tests image
Product: [Fedora] Fedora Container Images Reporter: Jakub Čajka <jcajka>
Component: Container ReviewAssignee: Tomas Tomecek <ttomecek>
Status: MODIFIED --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: container-review, ttomecek
Target Milestone: ---Flags: ttomecek: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Jakub Čajka 2018-11-01 12:25:36 UTC 
Container Build Info URL: https://pagure.io/origin-dockerfiles/blob/master/f/3.11/tests/Dockerfile
Description: This is the official OpenShift test image. It can be used to verify  an installation of OpenShift completed successfully.
Fedora Account System Username: jcajka
Comment 1 Tomas Tomecek 2018-11-01 12:51:01 UTC 
```
# FROM registry.fedoraproject.org/f29/origin-cli
FROM origin-cli
```

Shouldn't this be set to the line which is commented out? Or did we finally got rid of the $FGC prefix?

Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`?


Otherwise LGTM.
Comment 2 Jakub Čajka 2018-11-01 13:09:01 UTC 
(In reply to Tomas Tomecek from comment #1)
> ```
> # FROM registry.fedoraproject.org/f29/origin-cli
> FROM origin-cli
> ```
> 
> Shouldn't this be set to the line which is commented out? Or did we finally
> got rid of the $FGC prefix?
> 
> Actually, the same question, are we still doing FGC? `name="$FGC/$NAME" \`?
> 
> 
> Otherwise LGTM.

Yes, it will be the commented when the cli image will be in Fedora. You can build the whole stack using the build.sh script, although it might fail on some as they are waiting for latest origin package to hit stable in F29.
Comment 3 Tomas Tomecek 2018-11-05 13:07:58 UTC 
LGTM, approving
Comment 4 Gwyn Ciesla 2018-11-26 14:55:50 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/container/origin-tests