Bug 1645373

Summary: CVE-2018-14652 glusterfs: Buffer overflow in "features/locks" translator allows for denial of service [fedora-all]
Product: [Community] GlusterFS Reporter: Ravishankar N <ravishankar>
Component: locksAssignee: Ravishankar N <ravishankar>
Status: CLOSED NOTABUG QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 5CC: anoopcs, atumball, bugs, extras-qa, humble.devassy, jonathansteffan, kkeithle, matthias, ndevos, ramkrsna, ravishankar, sisharma, srangana
Target Milestone: ---Keywords: Security, SecurityTracking, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Release Note
Doc Text:
Story Points: ---
Clone Of: 1644761 Environment:
Last Closed: 2018-11-02 05:04:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1644579, 1644761    
Bug Blocks: 1632974, 1645363    

Description Ravishankar N 2018-11-02 04:50:27 UTC
+++ This bug was initially created as a clone of Bug #1644761 +++

+++ This bug was initially created as a clone of Bug #1644579 +++


This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of fedora-all.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When submitting as an update, use the fedpkg template provided in the next
comment(s).  This will include the bug IDs of this tracking bug as well as
the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
fedpkg commit message.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

--- Additional comment from Siddharth Sharma on 2018-10-31 04:12:01 EDT ---

Use the following template to for the 'fedpkg update' request to submit an
update for this issue as it contains the top-level parent bug(s) as well as
this tracking bug.  This will ensure that all associated bugs get updated
when new packages are pushed to stable.

=====

# bugfix, security, enhancement, newpackage (required)
type=security

# testing, stable
request=testing

# Bug numbers: 1234,9876
bugs=1632974,1644579

# Description of your update
notes=Security fix for [PUT CVEs HERE]

# Enable request automation based on the stable/unstable karma thresholds
autokarma=True
stable_karma=3
unstable_karma=-3

# Automatically close bugs when this marked as stable
close_bugs=True

# Suggest that users restart after update
suggest_reboot=False

======

Additionally, you may opt to use the bodhi web interface to submit updates:

https://bodhi.fedoraproject.org/updates/new

--- Additional comment from Ravishankar N on 2018-11-01 21:27:58 EDT ---

Hi Amar,
The fix for this patch is already present in master branch as a part of the commit 052849983e51a061d7fb2c3ffd74fa78bb257084 (https://review.gluster.org/#/c/glusterfs/+/20933/), which is not there in the release branches. Shall I move this BZ to modified, and send the relevant changes to fix the locks.c CVE alone to the supported release branch(es)?

--- Additional comment from Ravishankar N on 2018-11-01 23:40:48 EDT ---

Got an ack from Amar via email. Moving it to MODIFIED. Will be sending the fix for locks vulnerability alone on release branches.

Comment 1 Ravishankar N 2018-11-02 05:04:35 UTC
Ugh, I was trying to backport the fix and realized that the code changes are already there on the release 5 branch by virtue of rebase from master. Hence closing this bug.