Bug 1645676

Summary: [OCP] Catalog Item Not Saving Provider for OpenShift Providers
Product: Red Hat CloudForms Management Engine Reporter: juwatts
Component: AutomateAssignee: Greg McCullough <gmccullo>
Status: CLOSED CURRENTRELEASE QA Contact: Sudhir Mallamprabhakara <smallamp>
Severity: medium Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: high    
Version: 5.10.0CC: dmetzger, juwatts, lavenel, mkanoor, obarenbo, simaishi, tfitzger
Target Milestone: GAKeywords: Regression
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.10.0.23 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-12 16:51:22 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: CFME Core Target Upstream Version:
Embargoed:

Description juwatts 2018-11-02 19:51:00 UTC
Description of problem:
When a user creates a new Service Catalog Item based on the OpenShift Template Item Type and select an OpenShift provider, the provider is not saved upon creation of the service catalog item


Version-Release number of selected component (if applicable):
5.10.0.22.20181030184024_26956a0

How reproducible:
100%

Steps to Reproduce:
1. Add an OpenShift provider in the CFME appliance
2. Creating a new Service Catalog Item based on the OpenShift Template Item Type
3. Select the OpenShift provider that was just added for the Provider drop down and click Add
4. Verify the Service Catalog Item was created correctly
5. Navigate to the created Service Catalog Item and look at the Provider key

Actual results:
No provider displayed

Expected results:
The provider selected in step 3 is displayed.

Additional info:

This is causing the order of a service catalog to fail with the following error:
[----] I, [2018-11-02T14:30:42.557229 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateProvisionRequest#call_automate_event) Raised event [request_starting] to Automate
[----] I, [2018-11-02T14:30:42.557451 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateProvisionRequest#create_request_tasks) Creating request task instances for: <Provisioning Service [juwatts-test] from [juwatts-test]>...
[----] I, [2018-11-02T14:30:42.606377 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateProvisionTask#create_child_tasks) - creating service tasks for service <ServiceTemplateProvisionTask:7> with parent service <none>
[----] I, [2018-11-02T14:30:42.991289 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateContainerTemplate.automate_result_include_service_template?) Include Service Template <juwatts-test> : <true>
[----] I, [2018-11-02T14:30:42.992987 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) Setting Service Owning User to Name=Administrator, ID=1, Group to Name=EvmGroup-super_administrator, ID=2
[----] I, [2018-11-02T14:30:43.003841 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateProvisionTask#create_child_tasks) - created <0> service tasks for service <ServiceTemplateProvisionTask:7> with parent service <none>
[----] I, [2018-11-02T14:30:43.012206 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(ServiceTemplateProvisionTask#deliver_to_automate) Queuing Service_Template_Provisioning: [Provisioning [juwatts-test] for Service [juwatts-test]]...
[----] I, [2018-11-02T14:30:43.022734 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(MiqQueue.put) Message id: [29537],  id: [], Zone: [default], Role: [automate], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [MiqAeEngine.deliver], Timeout: [600], Priority: [100], State: [ready], Deliver On: [], Data: [], Args: [{:object_type=>"ServiceTemplateProvisionTask", :object_id=>7, :namespace=>"Service/Generic/StateMachines", :class_name=>"GenericLifecycle", :instance_name=>"provision", :automate_message=>"create", :attrs=>{"dialog_radio_button_1"=>"", "request"=>"clone_to_service", :service_action=>"Provision", "Service::Service"=>4}, :user_id=>1, :miq_group_id=>2, :tenant_id=>1}]
[----] I, [2018-11-02T14:30:43.050983 #31177:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_request_7]) MIQ(MiqQueue#delivered) Message id: [29534], State: [ok], Delivered in [2.298588012] seconds
[----] I, [2018-11-02T14:30:44.486734 #11013:d18f80]  INFO -- : MIQ(MiqServer#populate_queue_messages) Fetched 2 miq_queue rows for queue_name=generic, wcount=4, priority=200
[----] I, [2018-11-02T14:30:44.803673 #44773:d18f80]  INFO -- : MIQ(MiqPriorityWorker::Runner#get_message_via_drb) Message id: [29536], MiqWorker id: [67], Zone: [default], Role: [automate], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [MiqAeEngine.deliver], Timeout: [3600], Priority: [20], State: [dequeue], Deliver On: [], Data: [], Args: [{:object_type=>"ServiceTemplateProvisionRequest", :object_id=>7, :attrs=>{:event_type=>"request_approved", "EventStream::event_stream"=>1054, :event_stream_id=>1054}, :instance_name=>"Event", :user_id=>1, :miq_group_id=>2, :tenant_id=>1, :automate_message=>nil}], Dequeued in: [4.068539567] seconds
[----] I, [2018-11-02T14:30:44.803941 #44773:d18f80]  INFO -- : MIQ(MiqQueue#deliver) Message id: [29536], Delivering...
[----] I, [2018-11-02T14:30:44.809800 #44773:d18f80]  INFO -- : MIQ(MiqAeEngine.deliver) Delivering {:event_type=>"request_approved", "EventStream::event_stream"=>1054, :event_stream_id=>1054} for object [ServiceTemplateProvisionRequest.7] with state [] to Automate
[----] I, [2018-11-02T14:30:44.820552 #5455:d18f80]  INFO -- : MIQ(MiqGenericWorker::Runner#get_message_via_drb) Message id: [29537], MiqWorker id: [72], Zone: [default], Role: [automate], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [MiqAeEngine.deliver], Timeout: [600], Priority: [100], State: [dequeue], Deliver On: [], Data: [], Args: [{:object_type=>"ServiceTemplateProvisionTask", :object_id=>7, :namespace=>"Service/Generic/StateMachines", :class_name=>"GenericLifecycle", :instance_name=>"provision", :automate_message=>"create", :attrs=>{"dialog_radio_button_1"=>"", "request"=>"clone_to_service", :service_action=>"Provision", "Service::Service"=>4}, :user_id=>1, :miq_group_id=>2, :tenant_id=>1}], Dequeued in: [1.803155585] seconds
[----] I, [2018-11-02T14:30:44.820773 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(MiqQueue#deliver) Message id: [29537], Delivering...
[----] I, [2018-11-02T14:30:44.825267 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(MiqAeEngine.deliver) Delivering {"dialog_radio_button_1"=>"", "request"=>"clone_to_service", :service_action=>"Provision", "Service::Service"=>4} for object [ServiceTemplateProvisionTask.7] with state [] to Automate
[----] I, [2018-11-02T14:30:44.829719 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(ServiceTemplateProvisionTask#before_ae_starts) Executing Service_Template_Provisioning request: [Provisioning [juwatts-test] for Service [juwatts-test]]
[----] I, [2018-11-02T14:30:45.706190 #44773:d18f80]  INFO -- : MIQ(MiqQueue#delivered) Message id: [29536], State: [ok], Delivered in [0.902272087] seconds
[----] I, [2018-11-02T14:30:49.678901 #5455:86b16bc]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(ServiceContainerTemplate#on_error) on_error called for service: [juwatts-test] action: [Provision]
[----] E, [2018-11-02T14:30:49.718047 #5455:d18f80] ERROR -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(MiqAeEngine.deliver) Error delivering {"dialog_radio_button_1"=>"", "request"=>"clone_to_service", :service_action=>"Provision", "Service::Service"=>4} for object [ServiceTemplateProvisionTask.7] with state [] to Automate:
[----] I, [2018-11-02T14:30:49.718238 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(ServiceTemplateProvisionTask#after_ae_delivery) ae_result="error"
[----] I, [2018-11-02T14:30:49.778686 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(MiqQueue.put) Message id: [29538],  id: [], Zone: [default], Role: [automate], Server: [], MiqTask id: [], Ident: [generic], Target id: [], Instance id: [], Task id: [], Command: [MiqAeEngine.deliver], Timeout: [3600], Priority: [20], State: [ready], Deliver On: [], Data: [], Args: [{:object_type=>"ServiceContainerTemplate", :object_id=>4, :attrs=>{:event_type=>:service_provisioned, "MiqEvent::miq_event"=>1056, :miq_event_id=>1056, "EventStream::event_stream"=>1056, :event_stream_id=>1056}, :instance_name=>"Event", :user_id=>1, :miq_group_id=>2, :tenant_id=>1, :automate_message=>nil}]
[----] I, [2018-11-02T14:30:49.778978 #5455:d18f80]  INFO -- : Q-task_id([r7_service_template_provision_task_7]) MIQ(MiqQueue#delivered) Message id: [29537], State: [ok], Delivered in [4.958220945] seconds

Comment 5 CFME Bot 2018-11-06 08:32:23 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master:

https://github.com/ManageIQ/manageiq-ui-classic/commit/5a104e05436edaac4fe80c73d4225629985a6e6c
commit 5a104e05436edaac4fe80c73d4225629985a6e6c
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Nov  5 15:50:10 2018 -0500
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Nov  5 15:50:10 2018 -0500

    Fixed to show grouping in drop down only for Ansible Tower type item.

    Trying to use grouped_options_for_select for a drop down that does not have grouping was causing an error in the log and preventing from saving manager_id and template_id fields when adding a Catalog Item type of 'Openshift Template'

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645676

 app/views/catalog/_form_basic_info.html.haml | 14 +-
 1 file changed, 10 insertions(+), 4 deletions(-)

Comment 6 CFME Bot 2018-11-06 13:53:42 UTC
New commit detected on ManageIQ/manageiq-ui-classic/hammer:

https://github.com/ManageIQ/manageiq-ui-classic/commit/362db9e96e63f8f79ac19d468383d87831d78ddf
commit 362db9e96e63f8f79ac19d468383d87831d78ddf
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Tue Nov  6 03:31:20 2018 -0500
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Tue Nov  6 03:31:20 2018 -0500

    Merge pull request #4875 from h-kataria/fixed_container_template_drop_down

    Fixed to show grouping in drop down only for Ansible Tower type item.

    (cherry picked from commit 3c47c434d34da5627bc4fa0f5b15e2d14251e403)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1645676

 app/views/catalog/_form_basic_info.html.haml | 14 +-
 1 file changed, 10 insertions(+), 4 deletions(-)

Comment 7 juwatts 2018-11-07 21:45:38 UTC
Tested in 5.10.0.23.20181106165157_92dd189

Provider is now saved on the service catalog item. But the following error still appears when you the item is ordered:

Generic Service Error: Server [EVM] Service [juwatts-catalog-item] Provision Step [pre4] Status [Error Processing Preprocess]

Comment 9 Greg McCullough 2018-11-07 22:45:43 UTC
Justin, you will need to provide logs for the issue reported in comment #7.  

I would recommend that this issue be split into a separate BZ as the issue identified in the title/description was addressed.

Comment 10 juwatts 2018-11-08 13:20:38 UTC
Greg, I did mention this failure in the addition info section but I will split this off into a different PR that is more specific to the failure I am seeing. 

I will close this as verified when I get the new bug written and add it as a comment in this bug.

Comment 11 juwatts 2018-11-08 13:57:07 UTC
This bug has been verified, a new bug has been written for the failure observed when ordering the service:

https://bugzilla.redhat.com/show_bug.cgi?id=1647842