Bug 1645998

Summary: Review Request: perl-Data-ICal-DateTime - Convenience methods for using Data::ICal with DateTime
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Jitka Plesnikova <jplesnik>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: jplesnik, package-review
Target Milestone: ---Flags: jplesnik: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-18 07:22:19 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2018-11-05 06:46:55 UTC 
Spec URL: http://people.parinux.org/~seyman/fedora/perl-Data-ICal-DateTime/perl-Data-ICal-DateTime.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Data-ICal-DateTime/perl-Data-ICal-DateTime-0.82-1.fc29.src.rpm
Description:
Data::ICal::Datetime is a perl module which contains convenience methods
for using Data::ICal data with the DateTime perl module.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.
Comment 1 Jitka Plesnikova 2018-11-06 08:42:19 UTC 
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Data-ICal-DateTime-0.82-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Clone)
      1 perl(Data::ICal)
      1 perl(DateTime::Format::ICal)
      1 perl(DateTime::Set)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(strict)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Data-ICal-DateTime-0.82-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Data::ICal::DateTime) = 0.82
      1 perl-Data-ICal-DateTime = 0.82-1.fc30
Binary provides are Ok.

$ rpmlint ./perl-Data-ICal-DateTime*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

The package looks good.
Approved
Comment 2 Emmanuel Seyman 2018-11-06 08:48:34 UTC 
Thank you for the review, Jikta. I've requested the repo.
Comment 3 Gwyn Ciesla 2018-11-06 14:56:28 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-ICal-DateTime
Comment 4 Emmanuel Seyman 2018-11-18 07:22:19 UTC 
This package has been pushed to stable. Closing.