Bug 1646543
| Summary: | Review Request: dnf-plugin-ovl - DNF plugin to work around overlayfs issues | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Till Hofmann <thofmann> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, redhat-dwupv |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-11-18 02:57:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Till Hofmann
2018-11-05 16:15:53 UTC
Taking this review. The license file is missing from the sources and the package. Cf. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text (In reply to Neal Gompa from comment #2) > The license file is missing from the sources and the package. > > Cf. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#License_Text Thanks for pointing this out. Upstream does not ship a license, I've asked them to include it: https://github.com/FlorianLudwig/dnf-plugin-ovl/pull/2 Spec URL: https://thofmann.fedorapeople.org/dnf-plugin-ovl.spec SRPM URL: https://thofmann.fedorapeople.org/dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc28.src.rpm - Update to 0.0.2 - Use git snapshot to include latest upstream fixes - Install license file Package review: [x] Package is named correctly [x] Package follows general packaging guidelines [x] Package builds and installs correctly [x] Package licensing information is set correctly and accurate PACKAGE APPROVED. Thank you for the review! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/dnf-plugin-ovl dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc27 has been submitted as an update to Fedora 27. https://bodhi.fedoraproject.org/updates/FEDORA-2018-1972ffffb3 dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8413279368 dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-59665bc09f dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc27 has been pushed to the Fedora 27 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-1972ffffb3 dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8413279368 dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-59665bc09f dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc27 has been pushed to the Fedora 27 stable repository. If problems still persist, please make note of it in this bug report. I had this failure just now with overlay2 in Docker Fedora 29: dnf clean all error: rpmdb: damaged header #680 retrieved -- skipping. Docker version 18.09.1, build 4c52b90 fedora:29 d09302f77cfc dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc29.noarch In looking at the code, I think the file actually needs to be opened with O_CREAT. When I run touch /var/lib/rpm/*, I do not get the error. (In reply to Rob Nagler from comment #17) > I had this failure just now with overlay2 in Docker Fedora 29: > > dnf clean all > error: rpmdb: damaged header #680 retrieved -- skipping. > > Docker version 18.09.1, build 4c52b90 > fedora:29 d09302f77cfc > dnf-plugin-ovl-0.0.2-1.20181107gitfd1a5a5.fc29.noarch > > In looking at the code, I think the file actually needs to be opened with > O_CREAT. When I run touch /var/lib/rpm/*, I do not get the error. Is this a bug report? If so, you should probably open a new ticket. Although this looks like something that should be fixed upstream: https://github.com/FlorianLudwig/dnf-plugin-ovl I reported in https://github.com/FlorianLudwig/dnf-plugin-ovl/issues/3 As to why I reported it here... This comments above clearly state: If problems still persist, please make note of it in this bug report. |