Bug 1647234

Summary: [RFE] [Code Cleanup] Incorporate filtering/sorting/pagination abstraction with PlanVmsList
Product: Red Hat CloudForms Management Engine Reporter: Mike Turley <mturley>
Component: V2VAssignee: Brett Thurber <bthurber>
Status: CLOSED ERRATA QA Contact: Yadnyawalk Tale <ytale>
Severity: low Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: low    
Version: 5.10.0CC: fdupont, kkulkarn, mfeifer, micro, simaishi, smallamp
Target Milestone: GAKeywords: FutureFeature
Target Release: 5.10.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: v2v
Fixed In Version: 5.10.0.24 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-02-07 23:03:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Attachments:
Description Flags
do not have type menus none

Description Mike Turley 2018-11-06 22:50:44 UTC 
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Mike Turley 2018-11-06 22:53:41 UTC 
GH Issue: https://github.com/ManageIQ/manageiq-v2v/issues/762
GH PR: https://github.com/ManageIQ/manageiq-v2v/pull/777

This will be a refactor with no new functionality. To test it, we should verify that the sorting and pagination still work correctly in the list view displayed on the detail page for a migration plan that has not started.
Comment 3 CFME Bot 2018-11-08 18:07:20 UTC 
New commit detected on ManageIQ/manageiq-v2v/hammer:

https://github.com/ManageIQ/manageiq-v2v/commit/7bdf80d617ba98f1910cdd021e699b51d2c4171a
commit 7bdf80d617ba98f1910cdd021e699b51d2c4171a
Author:     Michael Ro <mikerodev>
AuthorDate: Wed Nov  7 08:34:00 2018 -0500
Commit:     Michael Ro <mikerodev>
CommitDate: Wed Nov  7 08:34:00 2018 -0500

    Merge pull request #777 from mturley/762-sort-paginate-plan-vms

    [#762] [Code Cleanup] Incorporate <ListViewToolbar /> with PlanVmsList

    (cherry picked from commit 242dbe7aad8cef38374071bf08d53dd37cb34d65)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1647234

 app/javascript/react/screens/App/Plan/components/PlanVmsList.js | 289 +-
 1 file changed, 20 insertions(+), 269 deletions(-)
Comment 4 Yadnyawalk Tale 2018-11-16 13:54:53 UTC 
Filtering, sorting and pagination working as earlier with refactor, no issues with that. Tested on 5.10.0.24.20181113213923_03b81fd

@Michael, I am assuming you are aware of we do not have sortTypeMenu and filterFieldTypeMenu dropdowns in PlanVmsList details page, please ignore if this is intentional (We have that on plans list views of Overview page though)
Comment 5 Yadnyawalk Tale 2018-11-16 13:56:13 UTC 
Created attachment 1506418 [details]
do not have type menus
Comment 6 Yadnyawalk Tale 2018-11-16 14:17:19 UTC 
"..for the not started plans, we only sort by name, and due to PF conventions, there is no dropdown selector there and .. we only have a single filter criterion (name), so similarly, no select dropdown.."

Thanks for clearing this thing @Michael.
Comment 7 errata-xmlrpc 2019-02-07 23:03:56 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:0212