Bug 1647252

Summary: VDO resource agent shouldn't be monitoring 'vdostats vdo_vol'
Product: Red Hat Enterprise Linux 7 Reporter: Corey Marthaler <cmarthal>
Component: resource-agentsAssignee: Oyvind Albrigtsen <oalbrigt>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7.6CC: agk, cluster-maint, fdinitto, rbednar
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: resource-agents-4.1.1-14.el7 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-06 12:01:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Corey Marthaler 2018-11-07 00:28:43 UTC 
Description of problem:
It should instead be using the volume name given. Currently this results in the following monitor notices. 

vdo_monitor()
        MODE=$(vdostats vdo_vol --verbose | grep "operating mode" | awk '{print $NF}')

Nov  6 18:06:03 harding-02 lrmd[10489]:  notice: vdo_resource_monitor_10000:36921:stderr [ 'vdo_vol': No such file or directory ]
Nov  6 18:06:14 harding-02 lrmd[10489]:  notice: vdo_resource_monitor_10000:37023:stderr [ 'vdo_vol': No such file or directory ]
Nov  6 18:06:26 harding-02 lrmd[10489]:  notice: vdo_resource_monitor_10000:37114:stderr [ 'vdo_vol': No such file or directory ]


If you change it to use the same check as in vdo_start() then it appears to work:

        MODE=$(vdostats --verbose ${OCF_RESKEY_volume} | grep "operating mode" | awk '{print $NF}')



Version-Release number of selected component (if applicable):
resource-agents-4.1.1-13.el7.x86_64


How reproducible:
Everytime
Comment 3 Roman Bednář 2019-06-11 11:28:13 UTC 
Marking verified.


# grep -A 3 'vdo_monitor()' /usr/lib/ocf/resource.d/heartbeat/vdo-vol
vdo_monitor(){
	status=$(vdo status $OPTIONS 2>&1)
	MODE=$(vdostats --verbose ${OCF_RESKEY_volume} | grep "operating mode" | awk '{print $NF}')

# rpm -qa | grep resource-agents
resource-agents-4.1.1-23.el7.x86_64
Comment 5 errata-xmlrpc 2019-08-06 12:01:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:2012