Bug 1647689

Summary:	Review Request: perl-Template-Multilingual - Multilingual templates for Template Toolkit
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-18 07:22:18 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2018-11-08 07:03:47 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Template-Multilingual/perl-Template-Multilingual.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Template-Multilingual/perl-Template-Multilingual-1.00-1.fc29.src.rpm
Description:
This subclass of Template Toolkit's Template class supports multilingual
templates: templates that contain text in several languages.

Fedora Account System Username: eseyman
Rpmlint Output: 1 packages and 1 specfiles checked; 0 errors, 0 warnings.

Comment 1 Jitka Plesnikova 2018-11-08 08:31:39 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
TODO: perl(ExtUtils::MakeMaker) can be removed from BR, because Makefile.PL
      is not used.

$ rpm -qp --requires perl-Template-Multilingual-1.00-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(base)
      1 perl(:MODULE_COMPAT_5.28.0)
      1 perl(strict)
      1 perl(Template)
      1 perl(Template::Multilingual::Parser)
      1 perl(Template::Parser)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-Template-Multilingual-1.00-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Template::Multilingual) = 1.00
      1 perl-Template-Multilingual = 1.00-1.fc30
      1 perl(Template::Multilingual::Parser) = 1.00
Binary provides are Ok.

$ rpmlint ./perl-Template-Multilingual*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

Please consider fixing 'TODO' item.

The package looks good.
Approved

Comment 2 Emmanuel Seyman 2018-11-08 08:39:16 UTC

(In reply to Jitka Plesnikova from comment #1)
>
> TODO: perl(ExtUtils::MakeMaker) can be removed from BR, because Makefile.PL
>       is not used.

Indeed. I've done this locally on the src.rpm that will be imported.

> The package looks good.
> Approved

Woot! Thank you, Jikta.
I've requested the repo and f29, f28 branches.

Comment 3 Gwyn Ciesla 2018-11-08 14:31:27 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Template-Multilingual

Comment 4 Emmanuel Seyman 2018-11-18 07:22:18 UTC

This package has been pushed to stable. Closing.