Bug 164837

Summary:

Use GET for buildsys web forms

Product:

[Retired] Fedora Infrastructure

Reporter:

Ville Skyttä <scop>

Component:

extras buildsys

Assignee:

Seth Vidal <skvidal>

Status:

CLOSED RAWHIDE

QA Contact:

Jeremy Katz <katzj>

Severity:

medium

Docs Contact:

Priority:

medium

Version:

unspecified

CC:

katzj

Target Milestone:

---

Keywords:

FutureFeature, Patch

Target Release:

---

Hardware:

All

OS:

Linux

Whiteboard:

Fixed In Version:

Doc Type:

Enhancement

Doc Text:

Story Points:

---

Clone Of:

Environment:

Last Closed:

2005-08-11 19:33:59 UTC

Type:

---

Regression:

---

Mount Type:

---

Documentation:

---

CRM:

Verified Versions:

Category:

---

oVirt Team:

---

RHEL 7.3 requirements from Atomic Host:

Cloudforms Team:

---

Target Upstream Version:

Embargoed:

Attachments:

Description	Flags
Use GET for web UI forms	none

Description Ville Skyttä 2005-08-01 18:30:40 UTC

Attached is a patch for the buildsys web interface, changing use of POST to  
GET for all forms: there's not that much data sent that would need POST, and  
using GET makes the UI more back/forward/reload friendly in browsers.  
Untested, but "trivial, should work (tm)".

Comment 1 Ville Skyttä 2005-08-01 18:30:47 UTC

Created attachment 117351 [details]
Use GET for web UI forms

Comment 2 Seth Vidal 2005-08-01 18:41:59 UTC

try appending email= to the strings in the current web interface.

I think you'll find they just work.

Comment 3 Seth Vidal 2005-08-01 18:42:37 UTC

an example:
http://buildsys.fedoraproject.org/build-status/indiv.psp?email=skvidal@phy.duke.edu

Comment 4 Ville Skyttä 2005-08-02 07:51:17 UTC

Sure, but why on earth should I have to type something to the URL while there's
a web interface for human consumption for it?

A counterexample:

Enter "117" to the "Job ID" text box, and click "Go".  Now, hit the browser's
reload button and be annoyed by the browser's confirmation dialog about
resending the form POST data.  If GET was used instead of POST, this would Just
Work(tm).

Comment 5 Dan Williams 2005-08-11 19:33:59 UTC

committed to CVS, will be in 0.3.1