Bug 1648623

Summary:	[UI] Warn that bond names >10 may explode with vlan
Product:	[oVirt] ovirt-engine	Reporter:	Michael Burman <mburman>
Component:	BLL.Network	Assignee:	Ales Musil <amusil>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Michael Burman <mburman>
Severity:	medium	Docs Contact:
Priority:	low
Version:	4.2.0	CC:	bugs, danken, dholler
Target Milestone:	ovirt-4.3.5	Keywords:	Reopened
Target Release:	4.3.5.1	Flags:	rule-engine: ovirt-4.3+
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.5.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-07-30 14:08:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Network	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Michael Burman 2018-11-11 06:18:47 UTC

Description of problem:
vdsm should accept bond name longer than 15 characters if vlan network is attached 

There is a 15 characters limitation when creating a bond name, 
bond0123456789 - valid
bond0123456789bond - not valid
bond0_new_bond - valid with BZ 1403653
bond0_new_bond1234 - not valid

vdsm should accept attaching vlan tagged networks to a valid bond names and don't explode with the 15 characters limitation :

2018-11-11 08:05:48,454+0200 INFO  (jsonrpc/5) [api.network] FINISH setupNetworks error=[Errno 8] Input data out of range from=::ffff:10.35.163.149,41552 (api:50)
2018-11-11 08:05:48,454+0200 ERROR (jsonrpc/5) [jsonrpc.JsonRpcServer] Internal server error (__init__:611)
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 606, in _handle_request
    res = method(**params)
  File "/usr/lib/python2.7/site-packages/vdsm/rpc/Bridge.py", line 197, in _dynamicMethod
    result = fn(*methodArgs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib/python2.7/site-packages/vdsm/common/api.py", line 48, in method
    ret = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/API.py", line 1525, in setupNetworks
    supervdsm.getProxy().setupNetworks(networks, bondings, options)
  File "/usr/lib/python2.7/site-packages/vdsm/common/supervdsm.py", line 55, in __call__
    return callMethod()
  File "/usr/lib/python2.7/site-packages/vdsm/common/supervdsm.py", line 53, in <lambda>
    **kwargs)
  File "<string>", line 2, in setupNetworks
  File "/usr/lib64/python2.7/multiprocessing/managers.py", line 773, in _callmethod
    raise convert_to_error(kind, result)
IOError: [Errno 8] Input data out of range


Version-Release number of selected component (if applicable):
vdsm-4.20.43-1.el7ev.x86_64
4.2.8_SNAPSHOT-133.g50935e9.0.scratch.master.el7ev

How reproducible:
100%

Steps to Reproduce:
1. Create bond0123456789 and attach vlan tagged network to it, approve operation

Actual results:
2018-11-11 08:05:48,454+0200 INFO  (jsonrpc/5) [api.network] FINISH setupNetworks error=[Errno 8] Input data out of range from=::ffff:10.35.163.149,41552 (api:50)
2018-11-11 08:05:48,454+0200 ERROR (jsonrpc/5) [jsonrpc.JsonRpcServer] Internal server error (__init__:611)

Expected results:
vdsm should accept attaching vlan tagged network to a valid bond names even if exceeded 15 characters.

Comment 1 Dan Kenigsberg 2018-11-12 09:57:01 UTC

Vdsm cannot do this. bond (as any other interface) names are limited by kernel. Engine should make it harder to generate/use too-long interface names, not vdsm.

Comment 2 Red Hat Bugzilla Rules Engine 2018-11-12 09:58:58 UTC

Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 7 Dominik Holler 2019-02-14 08:46:44 UTC

Maybe we can adopt the fix of bug 1666913 here.

Comment 8 Michael Burman 2019-06-25 05:48:36 UTC

Verified on 4.3.5.1-0.1.el7

Comment 9 Sandro Bonazzola 2019-07-30 14:08:12 UTC

This bugzilla is included in oVirt 4.3.5 release, published on July 30th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.5 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.