Bug 1649766

Summary:	User input handled incorrectly in preview
Product:	Red Hat Satellite	Reporter:	Lukáš Hellebrandt <lhellebr>
Component:	Reporting	Assignee:	Marek Hulan <mhulan>
Status:	CLOSED ERRATA	QA Contact:	Lukáš Hellebrandt <lhellebr>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	6.5.0	CC:	inecas, mhulan, oprazak, pcreech
Target Milestone:	6.5.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-1.20.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-14 12:38:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukáš Hellebrandt 2018-11-14 13:36:02 UTC

Description of problem:
When trying to preview a report, user input is handled incorrectly. Its value is probably not passed or plainly wrong. In default templates, this leads to empty dataset. When I remove the search from the default template, preview shows full dataset. When generating report normally, user input works.

Version-Release number of selected component (if applicable):
Reproduced on Sat 6.5 snap 3

How reproducible:
Deterministic

Steps to Reproduce:
1. Monitoring -> Report Templates -> <some_default_template> -> Preview

Actual results:
Empty dataset

Expected results:
Dataset for the selected host

Comment 1 Marek Hulan 2018-11-14 13:40:58 UTC

As described in inputs help, if input is not ready, it's replaced with "$USER_INPUT['name']" string. Of course that's not a valid syntax for searching. This is limitation known from older Satellite versions, I'd suggest turning this into RFE for "allowing specify custom values for user inputs when previewing template" or "define sample preview value at input definition" based on what you'd prefer as a solution.

Comment 2 Lukáš Hellebrandt 2018-11-14 13:56:49 UTC

Does this mean preview won't work for most of the templates using user input?

Comment 3 Marek Hulan 2018-11-14 14:25:58 UTC

Preview works, but if the user input is used the way all our default templates use it - for searching the records - the result will always be empty. But I understand, the fact you're seeing empty result for preview is not very useful. We could disable the preview for 6.5, but that would probably be worse. After short conversation on IRC, it seems for 6.5 it would be reasonable to use empty string as a value in preview. We need to check whether it will be compatible with REX templates.

Comment 4 Marek Hulan 2018-11-14 15:02:15 UTC

Created redmine issue https://projects.theforeman.org/issues/25466 from this bug

Comment 6 Satellite Program 2018-11-14 17:04:50 UTC

Upstream bug assigned to mhulan

Comment 7 Satellite Program 2018-11-14 17:04:52 UTC

Upstream bug assigned to mhulan

Comment 9 Lukáš Hellebrandt 2018-12-11 15:27:41 UTC

Verified with Sat 6.5 snap 7 using reproducer from OP.

Comment 11 errata-xmlrpc 2019-05-14 12:38:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1222