Bug 1649874
Summary: | Review Request: hpx - a general purpose C++ runtime system for parallel and distributed applications of any scale | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Christoph Junghans <junghans> |
Component: | Package Review | Assignee: | Luis Segundo <luis> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | bazanluis20, luis, mhroncok, package-review, patrickdiehl1 |
Target Milestone: | --- | Flags: | luis:
fedora-review+
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2018-12-02 07:36:49 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Christoph Junghans
2018-11-14 16:41:55 UTC
Since HPX 1.2 was released this Monday the hpx.spec file was updated to 1.2 instead of using the release candidate and can be found here https://github.com/diehlpk/hpx_packaging/blob/fedora/29/Fedora/hpx.spec @Luis Bazan: https://github.com/diehlpk/hpx_packaging/blob/fedora/29/Fedora/hpx.spec and https://fedorapeople.org/~junghans/hpx.spec are the same spec files. Hi Christoph this BZ is duplicated https://bugzilla.redhat.com/show_bug.cgi?id=1648498 Cheers, Hi Christoph and Patrick Can we clarify which of the bz we should attend? BZ 1649874 or 1648498?. Cheers, I can close this BZ and continue with 1648498? Cheers, Yes, for me both are fine, as long I and Christoph could maintain the package. *** Bug 1648498 has been marked as a duplicate of this bug. *** @Luis Bazan, there was something flaky going on in the i686 build, so I made revision bump incl. https://github.com/STEllAR-GROUP/hpx/pull/3551 Spec URL: https://fedorapeople.org/~junghans/hpx.spec SRPM URL: https://fedorapeople.org/~junghans/hpx-1.2.0-2.fc29.src.rpm TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=30901371 Hi Christoph please check the following error scratch build of hpx-1.2.0-2.fc29.src.rpm for rawhide failed http://koji.fedoraproject.org/koji/taskinfo?taskID=30904001 make: *** [Makefile:144: all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.eaHZQU (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.eaHZQU (%build) Child return code was: 1 EXCEPTION: [Error()] Traceback (most recent call last): File "/usr/lib/python3.6/site-packages/mockbuild/trace_decorator.py", line 89, in trace result = func(*args, **kw) File "/usr/lib/python3.6/site-packages/mockbuild/util.py", line 582, in do raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode) mockbuild.exception.Error: Command failed. See logs for output. # bash --login -c /usr/bin/rpmbuild -bb --target aarch64 --nodeps /builddir/build/SPECS/hpx.spec send me the rpmlint and link of koji when you fixed. regards Luis, did you change anything in the spec? My koji build worked, but looking at the error ("g++: fatal error: Killed signal terminated program cc1plus"), it seems it ran out of memory on aarch64, I will check. Spec URL: https://fedorapeople.org/~junghans/hpx.spec SRPM URL: https://fedorapeople.org/~junghans/hpx-1.2.0-3.fc29.src.rpm TaskID: https://koji.fedoraproject.org/koji/taskinfo?taskID=30922747 Spec looks good! License: Ok rpmlint hpx-1.2.0-3.fc29.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Package approved! regards (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/hpx How can I access the repo? We got following error when adding the user diehlpk to the repo? There is an error: "This user must be in one of the following groups to be allowed to be added to this project: packager" Hi Patrick -- Try again. Cheers, hpx-1.2.0-3.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-a9b53adbdc hpx-1.2.0-3.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-8367209bd8 hpx-1.2.0-3.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-8367209bd8 hpx-1.2.0-3.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-a9b53adbdc hpx-devel-1.2.0-3.fc30 requires /usr/bin/python2 hpx-examples-1.2.0-3.fc30 requires /usr/bin/python2 hpx-mpich-devel-1.2.0-3.fc30 requires /usr/bin/python2 hpx-mpich-examples-1.2.0-3.fc30 requires /usr/bin/python2 hpx-openmpi-devel-1.2.0-3.fc30 requires /usr/bin/python2 hpx-openmpi-examples-1.2.0-3.fc30requires /usr/bin/python2 Dependency on deprecated Python 2 is forbidden in new Fedora packages and this package should not have been approved as is. It the dependency intentional? Can it be switched to Python 3? Is it some forgotten script with shebang or main purpose executable of the package? Please get rid of the legacy Python dependency. List of files with python2 shebangs: /usr/bin/hpx_hpx_invoke.py /usr/bin/hpx_hpx_run_test.py /usr/bin/hpx_hpx_environment.py /usr/bin/hpx_hpxrun.py /usr/bin/hpx_hpx_optsweep.py /usr/bin/hpx_hpxcxx /usr/lib64/mpich/bin/hpx_hpx_invoke.py /usr/lib64/mpich/bin/hpx_hpx_run_test.py /usr/lib64/mpich/bin/hpx_hpxrun.py /usr/lib64/mpich/bin/hpx_hpx_optsweep.py /usr/lib64/mpich/bin/hpx_hpxcxx /usr/lib64/openmpi/bin/hpx_hpx_invoke.py /usr/lib64/openmpi/bin/hpx_hpx_run_test.py /usr/lib64/openmpi/bin/hpx_hpx_environment.py /usr/lib64/openmpi/bin/hpx_hpxrun.py /usr/lib64/openmpi/bin/hpx_hpx_optsweep.py /usr/lib64/openmpi/bin/hpx_hpxcxx /usr/lib64/mpich/bin/hpx_hpx_environment.py /usr/lib64/cmake/HPX/templates/hpxrun.py.in /usr/lib64/cmake/HPX/templates/hpxcxx.in /usr/lib64/mpich/lib/cmake/HPX/templates/hpxrun.py.in /usr/lib64/mpich/lib/cmake/HPX/templates/hpxcxx.in /usr/lib64/openmpi/lib/cmake/HPX/templates/hpxrun.py.in /usr/lib64/openmpi/lib/cmake/HPX/templates/hpxcxx.in @miro, the scripts should work with python3 as well, I will fix that shortly. Thank you, Christoph! Fixed in hpx-1.2.0-4. (In reply to Luis Segundo from comment #12) > Spec looks good! > License: Ok > > rpmlint hpx-1.2.0-3.fc29.src.rpm > 1 packages and 0 specfiles checked; 0 errors, 0 warnings. > > Package approved! > > regards Hi Luis can you review again please? f28 https://koji.fedoraproject.org/koji/buildinfo?buildID=1166328 f29 https://koji.fedoraproject.org/koji/buildinfo?buildID=1166327 f30 https://koji.fedoraproject.org/koji/buildinfo?buildID=1166326 hpx-1.2.0-4.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-282193eb69 hpx-1.2.0-4.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-9da04dcdf5 hpx-1.2.0-4.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-9da04dcdf5 hpx-1.2.0-4.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-282193eb69 Thank You. $ rpm -qp --requires hpx-* | grep python /usr/bin/python3 /usr/bin/python3 /usr/bin/python3 /usr/bin/python3 /usr/bin/python3 /usr/bin/python3 Hi Louis, I think that I still do not have commit access to the git repo [Patrick@thinpad hpx]$ bodhi updates request --user=diehlpk FEDORA-2018-282193eb69 stable diehlpk does not have commit access to hpx Best, Patrick hpx-1.2.0-4.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. hpx-1.2.0-4.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |