Bug 1650066

Summary:	Custom button with `display_for=List` displays on SUI summary page
Product:	Red Hat CloudForms Management Engine	Reporter:	Nikhil Dhandre <ndhandre>
Component:	UI - Service	Assignee:	Martin Hradil <mhradil>
Status:	POST ---	QA Contact:	Nikhil Dhandre <ndhandre>
Severity:	high	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	medium
Version:	5.10.0	CC:	bmidwood, dmetzger, hkataria, lavenel, smallamp
Target Milestone:	GA
Target Release:	5.10.z
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:		Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	CFME Core	Target Upstream Version:
Embargoed:

Description Nikhil Dhandre 2018-11-15 09:49:38 UTC

Description of problem:
-----------------------


Version-Release number of selected component (if applicable):
-------------------------------------------------------------
Version: 5.10.0.22.20181030184024_26956a0


How reproducible:
-----------------
Always


Steps to Reproduce:
-------------------
1. Create a custom button on `Service` object with the display for option as `List`

2. Navigate to MyService and check. It displays on `All` page but not on `Summary` Page

3. Now, Navigate to SSUI > MyServices. It's not displayed on `All` page  but displayed on `Summary` Page


Actual results:
---------------
List display for a button; display on the summary page of SSUI service.


Expected results:
-----------------
As per the custom button display_for option selection:
List: should only display on All page
Single: Should only display on the Summary page
Single and List: Should display on both Summery and All page


Additional info:
----------------

Comment 4 Allen W 2019-02-01 13:51:25 UTC

Hi Nikhil!  Would you mind checking if this is still an issue? there have been a number of updates to the custom buttons since this was filed, wondering if perhaps one of those fixed this, (and if not can yah provide an IP of a machine exhibiting the issue?)

Comment 7 Sudhir Mallamprabhakara 2019-07-23 14:25:47 UTC

This BZ has been reported and pending for a long time. It is blocking multiple automated tests. Can we have a target release for this?

Comment 10 Martin Hradil 2019-07-25 17:31:17 UTC

https://github.com/ManageIQ/manageiq-ui-service/pull/1566

Comment 11 CFME Bot 2019-08-13 15:51:21 UTC

New commit detected on ManageIQ/manageiq-ui-service/master:

https://github.com/ManageIQ/manageiq-ui-self_service/commit/420f00981c3c0c534e6e6a29819251bf20e61139
commit 420f00981c3c0c534e6e6a29819251bf20e61139
Author:     Martin Hradil <mhradil>
AuthorDate: Thu Jul 25 13:24:30 2019 -0400
Commit:     Martin Hradil <mhradil>
CommitDate: Thu Jul 25 13:24:30 2019 -0400

    Service detail - only show custom buttons for single/both, not list

    custom buttons with display_for='list' should only get shown on a service list screen,
    which the SUI doesn't have

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650066

 client/app/services/service-details/service-details.html | 6 +-
 1 file changed, 4 insertions(+), 2 deletions(-)