Bug 1650104
| Summary: | No Flash message appear when clicked on "Upload Chosen File" without choosing Custom Image File | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Niyaz Akhtar Ansari <nansari> | ||||||
| Component: | UI - OPS | Assignee: | Zita Nemeckova <znemecko> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | John Dupuy <jdupuy> | ||||||
| Severity: | medium | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||||
| Priority: | medium | ||||||||
| Version: | 5.10.0 | CC: | bmidwood, hkataria, lavenel, mfeifer, mpovolny, obarenbo, simaishi, znemecko | ||||||
| Target Milestone: | GA | ||||||||
| Target Release: | 5.11.0 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | 5.11.0.10 | Doc Type: | If docs needed, set a value | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2019-12-12 13:34:23 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/19a9641e3d2b68e8e1426d1ece37f1b7ad16f0c5 commit 19a9641e3d2b68e8e1426d1ece37f1b7ad16f0c5 Author: Zita Nemeckova <znemecko> AuthorDate: Fri Feb 22 03:54:55 2019 -0500 Commit: Zita Nemeckova <znemecko> CommitDate: Fri Feb 22 03:54:55 2019 -0500 Add error when clicking upload image without selecting a file Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1650104 app/assets/javascripts/components/generic_object/custom-image.js | 4 + app/views/static/generic_object/custom-image.html.haml | 4 +- 2 files changed, 7 insertions(+), 1 deletion(-) Verified that the "No file chosen." flash message does appear in CFME 5.11.0.7.20190605165356_fbab9f0. Steps of verification are the same as the steps of reproduction. However, I noticed that if you click the "Upload chosen File" multiple times, that the flash message will continually appear (see attachement). Is this behavior desired? I will leave this ON_QA until the needinfo is fulfilled. Created attachment 1579069 [details]
No file chosen continuously appearing
Displaying same message multiple times isn't good. Moving to ON_DEV. New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/f064c26f11d79f232f64d7973dfc5e0d575303f0 commit f064c26f11d79f232f64d7973dfc5e0d575303f0 Author: Zita Nemeckova <znemecko> AuthorDate: Tue Jun 11 13:08:01 2019 -0400 Commit: Zita Nemeckova <znemecko> CommitDate: Tue Jun 11 13:08:01 2019 -0400 Don't repeat error message Fix https://bugzilla.redhat.com/show_bug.cgi?id=1650104 app/assets/javascripts/components/generic_object/custom-image.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Verified in CFME 5.11.0.10 Steps of verification: 1.Go to automation->Automate->Generic Objects 2.Go to Create Generic Objects Class 3.Click on "Upload Chosen File" without choosing Custom Image File 4.Verified that he flash message appears and only appears once Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |
Created attachment 1506031 [details] flash Description of problem: Version-Release number of selected component (if applicable): Version 5.10.0.24.20181113213923_03b81fd How reproducible: 100% Steps to Reproduce: 1.Go to automation->Automate->Generic Objects 2.Go to Create Generic Objects Class 3.Click on "Upload Chosen File" without choosing Custom Image File Actual results: No Flash message appear when clicked on "Upload Chosen File" without choosing Custom Image File Expected results: Warning Flash message should appear Additional info: