Bug 1650452

Summary:	Backport smbc_setOptionProtocols() function
Product:	Red Hat Enterprise Linux 7	Reporter:	Ondrej Holy <oholy>
Component:	samba	Assignee:	Andreas Schneider <asn>
Status:	CLOSED ERRATA	QA Contact:	Andrej Dzilský <adzilsky>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	7.7	CC:	adzilsky, asn, bnocera, gdeschner, jarrpa, jstephen
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	samba-4.9.1-3.el7	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1658690 (view as bug list)		Environment:
Last Closed:	2019-08-06 12:45:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1619719, 1658690, 1739116

Description Ondrej Holy 2018-11-16 08:34:04 UTC

Workgroup browsing over libsmbclient API is broken with smb.conf defaults after RHEL 7.5 update, because "client max protocol" default value has been changed to PROTOCOL_LATEST, but NT1 is mandatory for workgroup functionality:
https://lists.samba.org/archive/samba-technical/2017-May/120768.html

Please backport smbc_setOptionProtocols() function, which allows forcing NT1 for libsmbclient clients:
https://github.com/samba-team/samba/commit/0dae4e2f5c65
https://github.com/samba-team/samba/commit/885435e8a4dc

This is necessary to fix "Windows Network" functionality in GNOME, see:
https://bugzilla.redhat.com/show_bug.cgi?id=1619719
https://gitlab.gnome.org/GNOME/gvfs/commit/6c8bc39f570e

Comment 2 Andreas Schneider 2018-12-12 16:44:15 UTC

Checked again, I think we are safe to update which means the so version gets bumped too.

Comment 5 Ondrej Holy 2019-02-13 16:55:48 UTC

I have tried to build gvfs with samba-4.9.1-1.el7, however gvfs doesn't see the smbc_setOptionProtocols function. It seems that the symbol is not part of the library:

$ wget -q http://download.eng.bos.redhat.com/brewroot/vol/rhel-7/packages/samba/4.9.1/1.el7/x86_64/libsmbclient-4.9.1-1.el7.x86_64.rpm
$ rpm2cpio libsmbclient-4.9.1-1.el7.x86_64.rpm | cpio -idmv 2> /dev/null
$ nm -D usr/lib64/libsmbclient.so.0 | grep smbc_setOption
000000000001b4f0 T smbc_setOptionBrowseMaxLmbCount
000000000001b4c0 T smbc_setOptionCaseSensitive
000000000001b3c0 T smbc_setOptionDebugToStderr
000000000001b580 T smbc_setOptionFallbackAfterKerberos
000000000001b430 T smbc_setOptionFullTimeNames
000000000001b5b0 T smbc_setOptionNoAutoAnonymousLogin
000000000001b530 T smbc_setOptionOneSharePerServer
000000000001b460 T smbc_setOptionOpenShareMode
000000000001b4a0 T smbc_setOptionSmbEncryptionLevel
000000000001b510 T smbc_setOptionUrlEncodeReaddirEntries
000000000001b5e0 T smbc_setOptionUseCCache
000000000001b550 T smbc_setOptionUseKerberos
000000000001b610 T smbc_setOptionUseNTHash
000000000001b480 T smbc_setOptionUserData
$ nm -D usr/lib64/libsmbclient.so.0 | grep smbc_setOptionProtocols
$

Andreas, can you please take a look at?

Comment 6 Andreas Schneider 2019-03-20 17:31:29 UTC

Fixed in new build.

Comment 9 errata-xmlrpc 2019-08-06 12:45:55 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:2099