Bug 1650464
| Summary: | [admin] Should not display No Roles Found when listing all Roles | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | XiaochuanWang <xiaocwan> |
| Component: | Management Console | Assignee: | Jon Jackson <jonjacks> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Yadan Pei <yapei> |
| Severity: | low | Docs Contact: | |
| Priority: | medium | ||
| Version: | 4.1.0 | CC: | aos-bugs, jokerman, mmccomas, spadgett |
| Target Milestone: | --- | ||
| Target Release: | 4.1.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: |
Cause:
Resources loaded through the ConnectToState component (in firehose.jsx) were considered collectively loaded if the loaded state of all required resources was true. Optional resources' loaded state was not being checked. This means that the loaded prop set by this component could be true before optional resources were finished loading.
Consequence:
When optional resources are passed to FIrehose, and no required resources exist, an empty state might be displayed momentarily before optional resources have a chance to finish loading.
Fix:
The logic for setting the 'loaded' prop created in ConnectToState is now as follows:
- Optional resources are considered loaded if and only if either their loaded state is true or their loadError state is not empty.
- Required resources are considered loaded if and only if their loaded state is true
- If all optional and required resources are considered loaded by the above logic, the loaded prop will be true.
Result:
An empty state is no longer displayed before optional components are finished loading.
|
Story Points: | --- |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-01-16 21:30:10 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
XiaochuanWang
2018-11-16 09:03:35 UTC
It only displays the Loading icon now. Mark it Verified on the version: $ oc get clusterversion NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.0.0-0.nightly-2019-01-15-010905 True False 11m Cluster version is 4.0.0-0.nightly-2019-01-15-010905 "version": "v4.0.0" "release": "0.139.0.0", |