Bug 1651536
| Summary: | pcp-system-tools's dstat does not parse arguments correctly | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Doncho Gunchev <dgunchev> |
| Component: | pcp | Assignee: | Nathan Scott <nathans> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 29 | CC: | edgar.hoch, fche, lberk, mgoodwin, nathans, scox, yuokada, zbyszek |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | pcp-4.3.0-1.fc29 pcp-4.3.0-2.fc28 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-12-24 06:07:29 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Doncho Gunchev
2018-11-20 09:52:51 UTC
Thanks Doncho - I have fixes for the -f/--full option problem and the TypeError issue in roundcsv(). I've CC'd yuokada who wrote the CSV code though, as I've noticed there's some other small inconsistencies there we should fix up too. pcp-4.3.0-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3dc05c6d19 pcp-4.3.0-1.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-3d0256193e pcp-4.3.0-1.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3d0256193e pcp-4.3.0-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-3dc05c6d19 pcp-4.3.0-1.fc29:
This works as expected:
# dstat -d -f
--dsk/sda-----dsk/sdb-----dsk/sdc--
read writ: read writ: read writ
0 0 :2810k 0 :2770k 74M
0 0 :2707k 1508k:7374k 37M
0 44k:3311k 0 : 16M 48M
# dstat -d -n -f
--dsk/sda-----dsk/sdb-----dsk/sdc-- net/enp1s0f--net/virbr0-net/virbr0--net/enp1s0f----net/lo--
read writ: read writ: read writ| recv send: recv send: recv send: recv send: recv send
0 0 :4098k 0 :9450k 1002k| 581 1076 : 0 0 : 0 0 : 0 0
0 0 :4040k 0 :8612k 3192k|2876k 21k: 0 0 : 0 0 : 0 0
0 0 :4534k 2763k: 14M 5686k|7278k 91k: 0 0 : 0 0 : 0 0
This is strange, but may be ok:
# dstat -d -D -f
No matching instances found.
But this crashes:
# dstat -D -f
You did not select any stats, using -cdngy by default.
Traceback (most recent call last):
File "/usr/bin/dstat", line 1632, in <module>
dstat.execute()
File "/usr/bin/dstat", line 1616, in execute
scheduler.run()
File "/usr/lib64/python3.7/sched.py", line 151, in run
action(*argument, **kwargs)
File "/usr/bin/dstat", line 1625, in perform
op.perform(update)
File "/usr/bin/dstat", line 1509, in perform
line = line + sep + self.gshow(plugin, results)
File "/usr/bin/dstat", line 1148, in gshow
metric = op.metrics[plugin.mgroup[0]]
IndexError: list index out of range
# dstat -d -f -a
Traceback (most recent call last):
File "/usr/bin/dstat", line 1632, in <module>
dstat.execute()
File "/usr/bin/dstat", line 1616, in execute
scheduler.run()
File "/usr/lib64/python3.7/sched.py", line 151, in run
action(*argument, **kwargs)
File "/usr/bin/dstat", line 1625, in perform
op.perform(update)
File "/usr/bin/dstat", line 1509, in perform
line = line + sep + self.gshow(plugin, results)
File "/usr/bin/dstat", line 1148, in gshow
metric = op.metrics[plugin.mgroup[0]]
IndexError: list index out of range
pcp-4.3.0-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. Edgar, it's best to file a new bug. With the backtrace it'll be easy to fix. (In reply to Zbigniew Jędrzejewski-Szmek from comment #8) > Edgar, it's best to file a new bug. With the backtrace it'll be easy to fix. Thanks. I have created bug 1661912. pcp-4.3.0-2.fc28 has been submitted as an update to Fedora 28. https://bodhi.fedoraproject.org/updates/FEDORA-2018-0913e3af78 pcp-4.3.0-2.fc28 has been pushed to the Fedora 28 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2018-0913e3af78 pcp-4.3.0-2.fc28 has been pushed to the Fedora 28 stable repository. If problems still persist, please make note of it in this bug report. |