Bug 165167

Summary: RHEL4: buffer overflow detected in fuser
Product: Red Hat Enterprise Linux 4 Reporter: Ulrich Drepper <drepper>
Component: psmiscAssignee: Karel Zak <kzak>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 4.0CC: security-response-team
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-09-05 20:03:14 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 176344    
Attachments:
Description Flags
Patch to fix a few sprintf problems. none

Description Ulrich Drepper 2005-08-04 20:09:57 UTC 
Description of problem:
I saw a message about a buffer overflow while my system was shutting down.  I
couldn't collect the message so I had to look at the sources.  There were no
_chk variants of the string functions used so it must have been the sprintf
call.  Low and behold, there are a couple of problems.  In kill_item (the
probably place of the message I saw) the buffer is too small for even a 5 digits
PID.  We nowadays can have 7 digits or more.  I looked through the code and
fixed a few more places which can cause problems.  Patch is attached.

Version-Release number of selected component (if applicable):
psmisc-21.5-4.

How reproducible:
Didn't try

Steps to Reproduce:
1.Don't know.  Shut down system with many of the system processes (I guess it
was NFS/autofs related) having high >= 10000 PIDs.
2.
3.
  
Actual results:
buffer overflow

Expected results:
no buffer overflow

Additional info:
Comment 1 Ulrich Drepper 2005-08-04 20:09:57 UTC 
Created attachment 117480 [details]
Patch to fix a few sprintf problems.
Comment 2 Karel Zak 2005-09-08 12:13:00 UTC 
Fixed in FC4 and FC5.
Comment 11 RHEL Program Management 2006-09-05 19:50:26 UTC 
The component this request has been filed against is not planned for inclusion
in the next update. The decision is based on weighting the priority and number
of requests for a component as well as the impact on the Red Hat Enterprise
Linux user-base: other components are considered having higher priority and the
number of changes we intend to include in update cycles is limited.
Comment 12 RHEL Program Management 2006-09-05 20:03:14 UTC 
Product Management has reviewed and declined this request.  You may appeal this
decision by reopening this request.