Bug 1651759

Summary: Review Request: rust-winapi-x86_64-pc-windows-gnu - Import libraries for the x86_64-pc-windows-gnu target.
Product: [Fedora] Fedora Reporter: Luis Segundo <luis>
Component: Package ReviewAssignee: Luis Bazan <bazanluis20>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: bazanluis20, eclipseo, luis, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2018-11-21 17:09:10 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Comment 1 Robert-André Mauchin 🐧 2018-11-20 21:57:33 UTC
Update your rust2rpm to the very latest version (from Rawhide), your generated SPEC use the old format. Also I don't see the point of packaging this, it seems Windows only like Winapi, why do you need it?

Comment 2 Luis Segundo 2018-11-21 01:15:33 UTC
Hello Robert,
I would like include this Package "dutree" more info https://docs.rs/dutree/0.2.9/dutree/

this package need the follow Dependencies
    getopts ^0.2
    regex ^0.2
    terminal_size ^0.1.7
    unicode-segmentation ^1.2.0
    unicode-width ^0.1.1

now "terminal_size" it's not include yet on fedora this one requiere the follow Dependencies

    libc ^0.2
    winapi ^0.3

"winapi" need the lib "winapi-x86_64-pc-windows-gnu" that I try to include


referecen
http://eminence.github.io/terminal-size/doc/terminal_size/index.html
https://docs.rs/winapi/0.3.6/winapi/

I will be waiting your comments

Thanks

Comment 3 Robert-André Mauchin 🐧 2018-11-21 10:59:04 UTC
This is not needed, when you package terminal_size, you need to patch the metadata (rust2rpm -p) to remove the windows only deps:


[target.'cfg(windows)'.dependencies]
winapi = { version = "0.3", features = ["winnt", "processenv", "wincon", "winbase"] }

Comment 4 Luis Segundo 2018-11-21 17:09:10 UTC
Hi Robert, 
thanks for the suggestion that worked for me,
I'll close this ticket

regards