Bug 1652060

Summary:	Singleton actions may not start after unclean shutdown
Product:	Red Hat Satellite	Reporter:	Adam Ruzicka <aruzicka>
Component:	Tasks Plugin	Assignee:	Adam Ruzicka <aruzicka>
Status:	CLOSED ERRATA	QA Contact:	Jan Hutař <jhutar>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	6.4	CC:	aruzicka, ehelms, inecas
Target Milestone:	6.5.0	Keywords:	Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	tfm-rubygem-dynflow-1.1.3,tfm-rubygem-katello-3.10.0.25-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1692806 (view as bug list)		Environment:
Last Closed:	2019-05-14 12:39:03 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1692806

Description Adam Ruzicka 2018-11-21 13:53:28 UTC

Description of problem:
We trigger singleton actions (LOCE, EQM) from dynflow's on_init hook. Recently we moved invalidation to happen after running the hooks. It is now possible to get into a situation where

1) On init hook is run, singleton actions fail because a lock is being held by another execution plan
2) Invalidation is performed, old actions fail with abnormal termination error and their locks are released
3) The satellite is left without LOCE and EQM

We used to do steps 1 and 2 in reverse order which worked, but changed that because of another issue.

Version-Release number of selected component (if applicable):
Satellite 6.4 and newer is most likely affected

How reproducible:
always

Steps to Reproduce:
0. (optional) Patch LOCE to make this easier to reproduce, add a lengthy sleep into its run method
1. systemctl kill --signal=9 foreman-tasks when the singleton action's step is running
2. systemctl restart foreman-tasks

Actual results:
New singleton actions fail with "$ACTION_CLASS is already active", old singleton actions fail with abnormal termination error, satellite is left without LOCE and EQM.

Expected results:
Old singleton actions get cleaned up, new are started.

Additional info:

Comment 1 Adam Ruzicka 2018-11-21 13:54:30 UTC

This is similar to https://bugzilla.redhat.com/show_bug.cgi?id=1652056, but not completely the same.

Comment 2 Adam Ruzicka 2018-11-23 11:55:33 UTC

Created redmine issue https://projects.theforeman.org/issues/25541 from this bug

Comment 9 Bryan Kearney 2019-02-25 09:06:49 UTC

Upstream bug assigned to aruzicka

Comment 11 Ivan Necas 2019-02-28 15:51:48 UTC

It turns out this was missed cherry-pick of https://github.com/Katello/katello/pull/7848/files, that I don's see in production

Comment 16 errata-xmlrpc 2019-05-14 12:39:03 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1222