Bug 1652677

Summary:	"Host Groups" menu item changed to "Host Group"
Product:	Red Hat Satellite	Reporter:	Lukáš Hellebrandt <lhellebr>
Component:	WebUI	Assignee:	Tomer Brisker <tbrisker>
WebUI sub component:	Foreman	QA Contact:	Lukáš Hellebrandt <lhellebr>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	bkearney, ehelms, mhulan, mzalewsk, oprazak, pcreech, sgraessl, zhunting
Version:	6.5.0	Keywords:	Triaged
Target Milestone:	6.5.0
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	foreman-1.20.1.4-1,foreman-1.20.1.17-1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-05-14 12:39:05 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lukáš Hellebrandt 2018-11-22 15:07:38 UTC

Description of problem:
Menu item Configure -> Host Groups has been changed to "Host Group" for no obvious reason. The commit with a bad translation is from year 2016 so I have no idea how that happened only for 6.5. However, it seems incorrect, given that the other items are in plural and there seems to be no tracker for this change.

Version-Release number of selected component (if applicable):
Reproduced on 6.5 snap 3.

Additional info:
Discussed this with Ondra who already has a fix.

Comment 1 Mirek Długosz 2018-11-22 15:33:40 UTC

I believe this and Bug 1651324 share the same root cause. Adding the other one to tracker - they aren't strictly duplicates, but solving one will hopefully solve another.

Ondra, Lukas:
as you have discussed it and have fix already, can you share how you will fix it and how this happened?
Since source of bad translation seems to be file last updated 2 years ago, I'm afraid something in our build pipeline might be broken. That would be very serious issue that could cause hard to discover bugs in many unrelated parts of Satellite. Can we rule that out?

Comment 2 Lukáš Hellebrandt 2018-11-22 15:39:36 UTC

I don't know a lot about the issue but:

1) msgid="Host Groups"
2) msgstr="Host Group"
3) Vertical navigation has been somehow reworked lately (source: mhulan).

=> I suppose the old one used msgid while the other uses (imo correctly) msgstr. But again, this might not be true at all.

Comment 3 Marek Hulan 2018-11-22 17:37:18 UTC

I don't know how that happened, but most likely this is unrelated to vert nav change that dropped HTML id attributes. This look more like a clash between upstream/downstream translations? Perhaps Eric or someone from his team knows, when and how we pull translation files during the build.

Comment 4 Ondřej Pražák 2018-11-26 07:53:51 UTC

Connecting redmine issue http://projects.theforeman.org/issues/25538 from this bug

Comment 8 Satellite Program 2018-12-31 15:05:41 UTC

Upstream bug assigned to tbrisker

Comment 9 Satellite Program 2018-12-31 15:05:42 UTC

Upstream bug assigned to tbrisker

Comment 10 Bryan Kearney 2019-01-07 21:12:52 UTC

Moving this bug to POST for triage into Satellite 6 since the upstream issue https://projects.theforeman.org/issues/25538 has been resolved.

Comment 14 Lukáš Hellebrandt 2019-02-01 11:14:25 UTC

FailedQA on Sat 6.5 snap 13.

The text is still "Host Group".

Comment 16 Lukáš Hellebrandt 2019-03-18 14:15:24 UTC

Verified with Sat 6.5 snap 20.

The menu item now says "Host Groups".

Comment 18 errata-xmlrpc 2019-05-14 12:39:05 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2019:1222

Comment 19 Red Hat Bugzilla 2023-09-14 04:42:44 UTC

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days